From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, avi@redhat.com, kvm@vger.kernel.org,
aliguori@us.ibm.com, kwolf@redhat.com
Subject: [PATCHv2 2/2] qemu: remove control vector save
Date: Wed, 1 Jul 2009 16:28:06 +0300 [thread overview]
Message-ID: <20090701132805.GC17278@redhat.com> (raw)
In-Reply-To: <cover.1246454826.git.mst@redhat.com>
control vector is saved/restored by virtio-pci,
it does not belong in virtio.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/hw/virtio.c b/hw/virtio.c
index 843be86..41e7ca2 100644
--- a/hw/virtio.c
+++ b/hw/virtio.c
@@ -626,9 +626,6 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f)
qemu_put_be32(f, vdev->config_len);
qemu_put_buffer(f, vdev->config, vdev->config_len);
- if (vdev->nvectors)
- qemu_put_be16s(f, &vdev->config_vector);
-
for (i = 0; i < VIRTIO_PCI_QUEUE_MAX; i++) {
if (vdev->vq[i].vring.num == 0)
break;
--
1.6.2.2
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, avi@redhat.com, kvm@vger.kernel.org,
aliguori@us.ibm.com, kwolf@redhat.com
Subject: [Qemu-devel] [PATCHv2 2/2] qemu: remove control vector save
Date: Wed, 1 Jul 2009 16:28:06 +0300 [thread overview]
Message-ID: <20090701132805.GC17278@redhat.com> (raw)
In-Reply-To: <cover.1246454826.git.mst@redhat.com>
control vector is saved/restored by virtio-pci,
it does not belong in virtio.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/hw/virtio.c b/hw/virtio.c
index 843be86..41e7ca2 100644
--- a/hw/virtio.c
+++ b/hw/virtio.c
@@ -626,9 +626,6 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f)
qemu_put_be32(f, vdev->config_len);
qemu_put_buffer(f, vdev->config, vdev->config_len);
- if (vdev->nvectors)
- qemu_put_be16s(f, &vdev->config_vector);
-
for (i = 0; i < VIRTIO_PCI_QUEUE_MAX; i++) {
if (vdev->vq[i].vring.num == 0)
break;
--
1.6.2.2
next prev parent reply other threads:[~2009-07-01 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1246454826.git.mst@redhat.com>
2009-07-01 13:28 ` [PATCHv2 1/2] fix segfault in msix_save Michael S. Tsirkin
2009-07-01 13:28 ` [Qemu-devel] " Michael S. Tsirkin
2009-07-01 13:28 ` Michael S. Tsirkin [this message]
2009-07-01 13:28 ` [Qemu-devel] [PATCHv2 2/2] qemu: remove control vector save Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090701132805.GC17278@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.