All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Ira Snyder <iws@ovro.caltech.edu>,
	linuxppc-dev@ozlabs.org, Andrey Gusev <a.gusev1980@mail.ru>,
	Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
	Timur Tabi <timur@freescale.com>
Subject: Re: [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path
Date: Thu, 2 Jul 2009 01:30:55 +0400	[thread overview]
Message-ID: <20090701213055.GA31167@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <0B693A82-F60B-4451-9747-1A54EAB64FEC@kernel.crashing.org>

On Wed, Jul 01, 2009 at 04:25:22PM -0500, Kumar Gala wrote:
> 
> On Jul 1, 2009, at 3:59 PM, Anton Vorontsov wrote:
> 
> >qe_ic is in the same boat, just as every other PIC controller. Heh..
> >doing some 'grep alloc_bootmem', it seems that there are pretty
> >much offenders. Let's fix them?
> >
> >arch/powerpc/platforms/82xx/pq2ads-pci-pic.c |    2 +-
> >arch/powerpc/sysdev/ipic.c                   |    4 +---
> >arch/powerpc/sysdev/mpic.c                   |    9 ++++-----
> >arch/powerpc/sysdev/qe_lib/qe_ic.c           |    4 +---
> >arch/powerpc/sysdev/uic.c                    |    3 +--
> >5 files changed, 8 insertions(+), 14 deletions(-)
> 
> mpic should already be fixed.. I just thing the pull occurred after
> -rc1 because of Ben being sick.

Fixed by this?

commit 85355bb272db31a3f2dd99d547eef794805e1319
Author: Kumar Gala <galak@kernel.crashing.org>
Date:   Thu Jun 18 22:01:20 2009 +0000

    powerpc: Fix mpic alloc warning


Then this isn't enough. There were two more calls of alloc_bootmem()
in mpic.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

  reply	other threads:[~2009-07-01 21:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01 19:08 bug in 2.6.31-rc1 Andrey Gusev
2009-07-01 19:48 ` Ira Snyder
2009-07-01 20:59   ` [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path Anton Vorontsov
2009-07-01 21:13     ` Timur Tabi
2009-07-01 21:28       ` Anton Vorontsov
2009-07-01 21:47         ` Timur Tabi
2009-07-01 21:25     ` Kumar Gala
2009-07-01 21:30       ` Anton Vorontsov [this message]
2009-07-01 21:48     ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090701213055.GA31167@oksana.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=a.gusev1980@mail.ru \
    --cc=arnd@arndb.de \
    --cc=galak@kernel.crashing.org \
    --cc=iws@ovro.caltech.edu \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.