From: Timur Tabi <timur@freescale.com>
To: avorontsov@ru.mvista.com
Cc: Arnd Bergmann <arnd@arndb.de>, Ira Snyder <iws@ovro.caltech.edu>,
linuxppc-dev@ozlabs.org, Andrey Gusev <a.gusev1980@mail.ru>,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: Re: [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path
Date: Wed, 01 Jul 2009 16:13:43 -0500 [thread overview]
Message-ID: <4A4BD187.8000605@freescale.com> (raw)
In-Reply-To: <20090701205957.GA9583@oksana.dev.rtsoft.ru>
Anton Vorontsov wrote:
> diff --git a/arch/powerpc/sysdev/qe_lib/qe_ic.c b/arch/powerpc/sysdev/qe_lib/qe_ic.c
> index 63cdf98..074905c 100644
> --- a/arch/powerpc/sysdev/qe_lib/qe_ic.c
> +++ b/arch/powerpc/sysdev/qe_lib/qe_ic.c
> @@ -333,12 +333,10 @@ void __init qe_ic_init(struct device_node *node, unsigned int flags,
> if (ret)
> return;
>
> - qe_ic = alloc_bootmem(sizeof(struct qe_ic));
> + qe_ic = kzalloc(sizeof(*qe_ic), GFP_KERNEL);
This function is called during init_IRQ() in main.c. Looking at the code, I don't see any earlier calls to kzalloc(). Are you sure this is supposed to work?
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2009-07-01 21:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 19:08 bug in 2.6.31-rc1 Andrey Gusev
2009-07-01 19:48 ` Ira Snyder
2009-07-01 20:59 ` [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path Anton Vorontsov
2009-07-01 21:13 ` Timur Tabi [this message]
2009-07-01 21:28 ` Anton Vorontsov
2009-07-01 21:47 ` Timur Tabi
2009-07-01 21:25 ` Kumar Gala
2009-07-01 21:30 ` Anton Vorontsov
2009-07-01 21:48 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4BD187.8000605@freescale.com \
--to=timur@freescale.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=a.gusev1980@mail.ru \
--cc=arnd@arndb.de \
--cc=avorontsov@ru.mvista.com \
--cc=iws@ovro.caltech.edu \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.