* [PATCH -tip] x86: Remove useless variable disable_x2apic
@ 2009-07-02 17:03 Jaswinder Singh Rajput
2009-07-02 17:14 ` Cyrill Gorcunov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jaswinder Singh Rajput @ 2009-07-02 17:03 UTC (permalink / raw)
To: Ingo Molnar, Yinghai Lu, Thomas Gleixner, Cyrill Gorcunov,
x86 maintainers, LKML
setup_nox2apic() is writing 1 to disable_x2apic but no one is reading it.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kernel/apic/apic.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 8c7c042..0a1c283 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -140,7 +140,6 @@ int x2apic_mode;
#ifdef CONFIG_X86_X2APIC
/* x2apic enabled before OS handover */
static int x2apic_preenabled;
-static int disable_x2apic;
static __init int setup_nox2apic(char *str)
{
if (x2apic_enabled()) {
@@ -149,7 +148,6 @@ static __init int setup_nox2apic(char *str)
return 0;
}
- disable_x2apic = 1;
setup_clear_cpu_cap(X86_FEATURE_X2APIC);
return 0;
}
--
1.6.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -tip] x86: Remove useless variable disable_x2apic
2009-07-02 17:03 [PATCH -tip] x86: Remove useless variable disable_x2apic Jaswinder Singh Rajput
@ 2009-07-02 17:14 ` Cyrill Gorcunov
2009-07-03 9:36 ` [tip:x86/urgent] x86: Remove unused " tip-bot for Jaswinder Singh Rajput
2009-07-03 12:45 ` tip-bot for Jaswinder Singh Rajput
2 siblings, 0 replies; 4+ messages in thread
From: Cyrill Gorcunov @ 2009-07-02 17:14 UTC (permalink / raw)
To: Jaswinder Singh Rajput
Cc: Ingo Molnar, Yinghai Lu, Thomas Gleixner, x86 maintainers, LKML,
Suresh Siddha
[Jaswinder Singh Rajput - Thu, Jul 02, 2009 at 10:33:59PM +0530]
|
| setup_nox2apic() is writing 1 to disable_x2apic but no one is reading it.
|
| Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
| ---
| arch/x86/kernel/apic/apic.c | 2 --
| 1 files changed, 0 insertions(+), 2 deletions(-)
|
| diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
| index 8c7c042..0a1c283 100644
| --- a/arch/x86/kernel/apic/apic.c
| +++ b/arch/x86/kernel/apic/apic.c
| @@ -140,7 +140,6 @@ int x2apic_mode;
| #ifdef CONFIG_X86_X2APIC
| /* x2apic enabled before OS handover */
| static int x2apic_preenabled;
| -static int disable_x2apic;
| static __init int setup_nox2apic(char *str)
| {
| if (x2apic_enabled()) {
| @@ -149,7 +148,6 @@ static __init int setup_nox2apic(char *str)
| return 0;
| }
|
| - disable_x2apic = 1;
| setup_clear_cpu_cap(X86_FEATURE_X2APIC);
| return 0;
| }
| --
| 1.6.2.5
|
yes, at moment we use cpu_has_x2apic mostly.
Ack. But lets CC Suresh to be sure. Maybe
there is something in plans.
-- Cyrill
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/urgent] x86: Remove unused variable disable_x2apic
2009-07-02 17:03 [PATCH -tip] x86: Remove useless variable disable_x2apic Jaswinder Singh Rajput
2009-07-02 17:14 ` Cyrill Gorcunov
@ 2009-07-03 9:36 ` tip-bot for Jaswinder Singh Rajput
2009-07-03 12:45 ` tip-bot for Jaswinder Singh Rajput
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Jaswinder Singh Rajput @ 2009-07-03 9:36 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, yinghai, jaswinder, gorcunov,
jaswinderrajput, tglx, mingo
Commit-ID: 87489b7a2be2d04432c246379484d9e030f64658
Gitweb: http://git.kernel.org/tip/87489b7a2be2d04432c246379484d9e030f64658
Author: Jaswinder Singh Rajput <jaswinder@kernel.org>
AuthorDate: Thu, 2 Jul 2009 22:33:59 +0530
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 3 Jul 2009 11:34:07 +0200
x86: Remove unused variable disable_x2apic
setup_nox2apic() is writing 1 to disable_x2apic but no one is reading it.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
LKML-Reference: <1246554239.2242.27.camel@jaswinder.satnam>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/apic/apic.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 8c7c042..0a1c283 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -140,7 +140,6 @@ int x2apic_mode;
#ifdef CONFIG_X86_X2APIC
/* x2apic enabled before OS handover */
static int x2apic_preenabled;
-static int disable_x2apic;
static __init int setup_nox2apic(char *str)
{
if (x2apic_enabled()) {
@@ -149,7 +148,6 @@ static __init int setup_nox2apic(char *str)
return 0;
}
- disable_x2apic = 1;
setup_clear_cpu_cap(X86_FEATURE_X2APIC);
return 0;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [tip:x86/urgent] x86: Remove unused variable disable_x2apic
2009-07-02 17:03 [PATCH -tip] x86: Remove useless variable disable_x2apic Jaswinder Singh Rajput
2009-07-02 17:14 ` Cyrill Gorcunov
2009-07-03 9:36 ` [tip:x86/urgent] x86: Remove unused " tip-bot for Jaswinder Singh Rajput
@ 2009-07-03 12:45 ` tip-bot for Jaswinder Singh Rajput
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Jaswinder Singh Rajput @ 2009-07-03 12:45 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, yinghai, jaswinder, gorcunov,
jaswinderrajput, tglx, mingo
Commit-ID: 23d0cd8e718723f1ddda37637bc6b7c34caec64a
Gitweb: http://git.kernel.org/tip/23d0cd8e718723f1ddda37637bc6b7c34caec64a
Author: Jaswinder Singh Rajput <jaswinder@kernel.org>
AuthorDate: Thu, 2 Jul 2009 22:33:59 +0530
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 3 Jul 2009 14:34:27 +0200
x86: Remove unused variable disable_x2apic
setup_nox2apic() is writing 1 to disable_x2apic but no one is reading it.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
LKML-Reference: <1246554239.2242.27.camel@jaswinder.satnam>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/apic/apic.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 8c7c042..0a1c283 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -140,7 +140,6 @@ int x2apic_mode;
#ifdef CONFIG_X86_X2APIC
/* x2apic enabled before OS handover */
static int x2apic_preenabled;
-static int disable_x2apic;
static __init int setup_nox2apic(char *str)
{
if (x2apic_enabled()) {
@@ -149,7 +148,6 @@ static __init int setup_nox2apic(char *str)
return 0;
}
- disable_x2apic = 1;
setup_clear_cpu_cap(X86_FEATURE_X2APIC);
return 0;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-07-03 12:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-02 17:03 [PATCH -tip] x86: Remove useless variable disable_x2apic Jaswinder Singh Rajput
2009-07-02 17:14 ` Cyrill Gorcunov
2009-07-03 9:36 ` [tip:x86/urgent] x86: Remove unused " tip-bot for Jaswinder Singh Rajput
2009-07-03 12:45 ` tip-bot for Jaswinder Singh Rajput
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.