* [PATCH] isofs: fix Joliet regression
@ 2009-07-08 17:29 Bartlomiej Zolnierkiewicz
2009-07-10 10:24 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-07-08 17:29 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-kernel
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] isofs: fix Joliet regression
commit 5404ac8e4418ab3d254950ee4f9bcafc1da20b4a ("isofs: cleanup mount
option processing") missed conversion of joliet option flag resulting
in non-working Joliet support.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
I really want to believe that this is just the unlucky coincidence with
the ongoing vfat madness...
fs/isofs/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: b/fs/isofs/inode.c
===================================================================
--- a/fs/isofs/inode.c
+++ b/fs/isofs/inode.c
@@ -142,6 +142,7 @@ static const struct dentry_operations is
struct iso9660_options{
unsigned int rock:1;
+ unsigned int joliet:1;
unsigned int cruft:1;
unsigned int hide:1;
unsigned int showassoc:1;
@@ -151,7 +152,6 @@ struct iso9660_options{
unsigned int gid_set:1;
unsigned int utf8:1;
unsigned char map;
- char joliet;
unsigned char check;
unsigned int blocksize;
mode_t fmode;
@@ -632,7 +632,7 @@ static int isofs_fill_super(struct super
else if (isonum_711(vdp->type) == ISO_VD_SUPPLEMENTARY) {
sec = (struct iso_supplementary_descriptor *)vdp;
if (sec->escape[0] == 0x25 && sec->escape[1] == 0x2f) {
- if (opt.joliet == 'y') {
+ if (opt.joliet) {
if (sec->escape[2] == 0x40)
joliet_level = 1;
else if (sec->escape[2] == 0x43)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] isofs: fix Joliet regression
2009-07-08 17:29 [PATCH] isofs: fix Joliet regression Bartlomiej Zolnierkiewicz
@ 2009-07-10 10:24 ` Jan Kara
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kara @ 2009-07-10 10:24 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-kernel
On Wed 08-07-09 19:29:52, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] isofs: fix Joliet regression
>
> commit 5404ac8e4418ab3d254950ee4f9bcafc1da20b4a ("isofs: cleanup mount
> option processing") missed conversion of joliet option flag resulting
> in non-working Joliet support.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> I really want to believe that this is just the unlucky coincidence with
> the ongoing vfat madness...
Thanks for the fix. I've just tracked this down as well and wanted to write
a fix :) I'll send the patch to Linus for inclusion.
Honza
> fs/isofs/inode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: b/fs/isofs/inode.c
> ===================================================================
> --- a/fs/isofs/inode.c
> +++ b/fs/isofs/inode.c
> @@ -142,6 +142,7 @@ static const struct dentry_operations is
>
> struct iso9660_options{
> unsigned int rock:1;
> + unsigned int joliet:1;
> unsigned int cruft:1;
> unsigned int hide:1;
> unsigned int showassoc:1;
> @@ -151,7 +152,6 @@ struct iso9660_options{
> unsigned int gid_set:1;
> unsigned int utf8:1;
> unsigned char map;
> - char joliet;
> unsigned char check;
> unsigned int blocksize;
> mode_t fmode;
> @@ -632,7 +632,7 @@ static int isofs_fill_super(struct super
> else if (isonum_711(vdp->type) == ISO_VD_SUPPLEMENTARY) {
> sec = (struct iso_supplementary_descriptor *)vdp;
> if (sec->escape[0] == 0x25 && sec->escape[1] == 0x2f) {
> - if (opt.joliet == 'y') {
> + if (opt.joliet) {
> if (sec->escape[2] == 0x40)
> joliet_level = 1;
> else if (sec->escape[2] == 0x43)
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] isofs: fix Joliet regression
@ 2009-07-10 10:34 Jan Kara
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kara @ 2009-07-10 10:34 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel, walt, Bartlomiej Zolnierkiewicz
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] isofs: fix Joliet regression
commit 5404ac8e4418ab3d254950ee4f9bcafc1da20b4a ("isofs: cleanup mount
option processing") missed conversion of joliet option flag resulting
in non-working Joliet support.
CC: walt <w41ter@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
---
Linus, please apply. Thanks.
fs/isofs/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: b/fs/isofs/inode.c
===================================================================
--- a/fs/isofs/inode.c
+++ b/fs/isofs/inode.c
@@ -142,6 +142,7 @@ static const struct dentry_operations is
struct iso9660_options{
unsigned int rock:1;
+ unsigned int joliet:1;
unsigned int cruft:1;
unsigned int hide:1;
unsigned int showassoc:1;
@@ -151,7 +152,6 @@ struct iso9660_options{
unsigned int gid_set:1;
unsigned int utf8:1;
unsigned char map;
- char joliet;
unsigned char check;
unsigned int blocksize;
mode_t fmode;
@@ -632,7 +632,7 @@ static int isofs_fill_super(struct super
else if (isonum_711(vdp->type) == ISO_VD_SUPPLEMENTARY) {
sec = (struct iso_supplementary_descriptor *)vdp;
if (sec->escape[0] == 0x25 && sec->escape[1] == 0x2f) {
- if (opt.joliet == 'y') {
+ if (opt.joliet) {
if (sec->escape[2] == 0x40)
joliet_level = 1;
else if (sec->escape[2] == 0x43)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-10 10:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-08 17:29 [PATCH] isofs: fix Joliet regression Bartlomiej Zolnierkiewicz
2009-07-10 10:24 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2009-07-10 10:34 Jan Kara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.