Questions in spi_mpc83xx.c

Questions in spi_mpc83xx.c

[Mark Bishop]

I haven't seen this before - the '##' in the function name.  This is ANCII C?

#define MPC83XX_SPI_TX_BUF(type)				\
u32 mpc83xx_spi_tx_buf_##type(struct mpc83xx_spi *mpc83xx_spi)	\
{								\
	u32 data;						\
....


Also, I have a SPI chip here that will drive MISO high when it is  
ready to accept more data.  It acts like a hardware handshake.  I was  
thinking about making changes to the controller source (spi_mpc83xx.c,  
in my case) to support this.

This is the only SPI chip contained on this system so I am not worried  
about affecting other SPI devices hooked to the controller.

What are people's opinion on this as far as right place to implement,  
and I could use a push as to where in the controller to make mods if  
appropriate.

And if it isn't obvious already I am still learning a bit as to how  
the SPI sub-system is organized.   I have taken apart the  
documentation in the kernel Documentation/spi directory and am reading  
all the code in drivers/spi.

Re: Questions in spi_mpc83xx.c

[Baruch Siach]

Hi Mark,

On Thu, Jul 09, 2009 at 02:16:48PM -0400, Mark Bishop wrote:
> I haven't seen this before - the '##' in the function name.  This is ANCII C?

Of course. See pp. 90-91 in "The C Programming Language" second edition.

> 
> #define MPC83XX_SPI_TX_BUF(type)				\
> u32 mpc83xx_spi_tx_buf_##type(struct mpc83xx_spi *mpc83xx_spi)	\
> {								\
> 	u32 data;						\
> ....

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge

Re: [spi-devel-general] Questions in spi_mpc83xx.c

[Baruch Siach]

Hi Mark,

On Thu, Jul 09, 2009 at 02:16:48PM -0400, Mark Bishop wrote:
> I haven't seen this before - the '##' in the function name.  This is ANCII C?

Of course. See pp. 90-91 in "The C Programming Language" second edition.

> 
> #define MPC83XX_SPI_TX_BUF(type)				\
> u32 mpc83xx_spi_tx_buf_##type(struct mpc83xx_spi *mpc83xx_spi)	\
> {								\
> 	u32 data;						\
> ....

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Re: [spi-devel-general] Questions in spi_mpc83xx.c

[Mark Bishop]

Quoting Baruch Siach <baruch@tkos.co.il>:

> Hi Mark,
>
> On Thu, Jul 09, 2009 at 02:16:48PM -0400, Mark Bishop wrote:
>> I haven't seen this before - the '##' in the function name.  This  
>> is ANCII C?
>
> Of course. See pp. 90-91 in "The C Programming Language" second edition.
>
>>


Wow, thanks.  I missed that little nugget of info.