Re: HTC Dream: qdsp support for staging

[Pavel Machek <pavel@ucw.cz>]

On Sat 2009-07-11 16:56:44, Daniel Walker wrote:
> On Sun, 2009-07-12 at 01:05 +0200, Pavel Machek wrote:
> > On Fri 2009-07-10 10:25:57, Daniel Walker wrote:
> > > On Fri, 2009-07-10 at 10:37 +0200, Pavel Machek wrote:
> > > > From: Iliyan Malchev <ibm@android.com>
> > > > 
> > > > QDSP code is neccessarry for communication with some hardware
> > > > components on HTC Dream, including camera hardware. It also drives DSP
> > > > coproccessor.
> > > > 
> > > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > 
> > > You don't want to break it up into multiple patches? I'll do it if you
> > > don't want too ..
> > 
> > I don't know how much sense it makes to split it further... yes, I
> > could probably split it per file or something but...
> > 
> > (Notice that this is going to be rewriten in staging, anyway, before
> > merging into kernel proper...)
> 
> Your expecting a full re-write? From a quick look this stuff just looks
> like it needs some TLC ..

I don't know what TLC means.

I expect a lot of changes; I did not study it in great enough detail;
but I suspect that the ammount of changes neccessary will drown any
initial changesets, so I guess it is simpler to just merge it in one piece.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html