From: Theodore Tso <tytso@mit.edu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Curt Wohlgemuth <curtw@google.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: RFC PATCH: ext4 no journal corruption with locale-gen
Date: Mon, 13 Jul 2009 09:05:07 -0400 [thread overview]
Message-ID: <20090713130507.GA12833@mit.edu> (raw)
In-Reply-To: <20090706153015.GB24136@skywalker>
On Mon, Jul 06, 2009 at 09:00:16PM +0530, Aneesh Kumar K.V wrote:
> > diff --git a/fs/ext4/ext4_jbd2.h b/fs/ext4/ext4_jbd2.h
> > index be2f426..f800134 100644
> > --- a/fs/ext4/ext4_jbd2.h
> > +++ b/fs/ext4/ext4_jbd2.h
> > @@ -282,7 +282,7 @@ static inline int ext4_should_order_data(struct inode *inode)
> > static inline int ext4_should_writeback_data(struct inode *inode)
> > {
> > if (EXT4_JOURNAL(inode) == NULL)
> > - return 0;
> > + return 1;
> > if (!S_ISREG(inode->i_mode))
> > return 0;
> > if (EXT4_I(inode)->i_flags & EXT4_JOURNAL_DATA_FL)
>
> We may want to change it after if (!S_ISREG(inode->i_mode))
> So that we don't return 1 for other than regular files.
Thanks for the suggestion; I've made this change.
- Ted
next prev parent reply other threads:[~2009-07-13 13:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 18:48 RFC PATCH: ext4 no journal corruption with locale-gen Curt Wohlgemuth
2009-06-17 23:46 ` Theodore Tso
2009-06-22 16:42 ` Curt Wohlgemuth
2009-06-22 16:56 ` Aneesh Kumar K.V
2009-06-22 17:01 ` Curt Wohlgemuth
2009-06-22 21:13 ` Andreas Dilger
2009-07-01 18:35 ` Aneesh Kumar K.V
2009-07-01 18:44 ` Michael Rubin
2009-07-02 23:27 ` Xiang Wang
2009-06-29 17:50 ` Curt Wohlgemuth
2009-07-01 18:31 ` Aneesh Kumar K.V
2009-07-06 3:41 ` Theodore Tso
2009-07-06 15:30 ` Aneesh Kumar K.V
2009-07-13 13:05 ` Theodore Tso [this message]
2009-07-06 16:21 ` Xiang Wang
2009-07-09 18:30 ` Xiang Wang
2009-07-10 7:28 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090713130507.GA12833@mit.edu \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.