From: Luis R. Rodriguez <lrodriguez@atheros.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 01/21] mac80211: drop frames for sta with no valid rate
Date: Wed, 15 Jul 2009 07:56:01 -0700 [thread overview]
Message-ID: <20090715145601.GA5682@mosca> (raw)
In-Reply-To: <1247659121.2477.1.camel@johannes.local>
On Wed, Jul 15, 2009 at 04:58:41AM -0700, Johannes Berg wrote:
> On Tue, 2009-07-14 at 20:13 -0400, Luis R. Rodriguez wrote:
>
> > + if (unlikely((tx->local->sw_scanning) &&
> > + (sta_flags & WLAN_STA_ASSOC) &&
> > + !rate_usable_index_exists(sband, &tx->sta->sta))) {
> > +#ifdef CONFIG_MAC80211_VERBOSE_DEBUG
> > + printk(KERN_DEBUG "%s: dropped data frame -- no "
> > + "supported rate for station %pM on %c GHz band\n",
> > + tx->dev->name, hdr->addr1,
> > + tx->channel->band ? '5' : '2');
> > +#endif /* CONFIG_MAC80211_VERBOSE_DEBUG */
> > + WARN_ON(1);
> > + return TX_DROP;
>
> Can you use WARN(),
sure.
> and put it into the if() please?
It is already in the if() branch, do you mean in the #ifdef?
Luis
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Subject: Re: [PATCH 01/21] mac80211: drop frames for sta with no valid rate
Date: Wed, 15 Jul 2009 07:56:01 -0700 [thread overview]
Message-ID: <20090715145601.GA5682@mosca> (raw)
In-Reply-To: <1247659121.2477.1.camel@johannes.local>
On Wed, Jul 15, 2009 at 04:58:41AM -0700, Johannes Berg wrote:
> On Tue, 2009-07-14 at 20:13 -0400, Luis R. Rodriguez wrote:
>
> > + if (unlikely((tx->local->sw_scanning) &&
> > + (sta_flags & WLAN_STA_ASSOC) &&
> > + !rate_usable_index_exists(sband, &tx->sta->sta))) {
> > +#ifdef CONFIG_MAC80211_VERBOSE_DEBUG
> > + printk(KERN_DEBUG "%s: dropped data frame -- no "
> > + "supported rate for station %pM on %c GHz band\n",
> > + tx->dev->name, hdr->addr1,
> > + tx->channel->band ? '5' : '2');
> > +#endif /* CONFIG_MAC80211_VERBOSE_DEBUG */
> > + WARN_ON(1);
> > + return TX_DROP;
>
> Can you use WARN(),
sure.
> and put it into the if() please?
It is already in the if() branch, do you mean in the #ifdef?
Luis
next prev parent reply other threads:[~2009-07-15 14:56 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 0:13 [ath9k-devel] [PATCH 00/21] ath9k/iwlwifi/mac80211: rate cleanup Luis R. Rodriguez
2009-07-15 0:13 ` Luis R. Rodriguez
2009-07-15 0:13 ` [ath9k-devel] [PATCH 01/21] mac80211: drop frames for sta with no valid rate Luis R. Rodriguez
2009-07-15 0:13 ` Luis R. Rodriguez
2009-07-15 11:58 ` [ath9k-devel] " Johannes Berg
2009-07-15 11:58 ` Johannes Berg
2009-07-15 14:56 ` Luis R. Rodriguez [this message]
2009-07-15 14:56 ` Luis R. Rodriguez
2009-07-15 16:05 ` [ath9k-devel] " Johannes Berg
2009-07-15 16:05 ` Johannes Berg
2009-07-15 0:13 ` [ath9k-devel] [PATCH 02/21] ath9k: downgrade assert in rc.c for invalid rate Luis R. Rodriguez
2009-07-15 0:13 ` Luis R. Rodriguez
2009-07-15 0:13 ` [ath9k-devel] [PATCH 03/21] iwlwifi: remove rs_get_rate workaround Luis R. Rodriguez
2009-07-15 0:13 ` Luis R. Rodriguez
2009-07-15 20:32 ` [ath9k-devel] " reinette chatre
2009-07-15 20:32 ` reinette chatre
2009-07-15 0:13 ` [ath9k-devel] [PATCH 04/21] ath9k: cleanup try count for MRR in rate control Luis R. Rodriguez
2009-07-15 0:13 ` Luis R. Rodriguez
2009-07-15 0:13 ` [ath9k-devel] [PATCH 05/21] ath9k: remove unused min rate calculation code Luis R. Rodriguez
2009-07-15 0:13 ` Luis R. Rodriguez
2009-07-15 0:13 ` [ath9k-devel] [PATCH 06/21] ath9k: remove unused stepdown when looking for the next rate Luis R. Rodriguez
2009-07-15 0:13 ` Luis R. Rodriguez
2009-07-15 0:13 ` [ath9k-devel] [PATCH 07/21] ath9k: remove pointless wrapper ath_rc_rate_getidx() Luis R. Rodriguez
2009-07-15 0:13 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 08/21] ath9k: rename ath_rc_get_nextlowervalid_txrate() Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 09/21] ath9k: remove unused ath_rc_isvalid_txmask() Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 10/21] ath9k: remove ATH9K_MODE_11B Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 11/21] ath9k: remap ATH9K_MODE_* Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 12/21] ath9k: rename ath_rc_ratefind_ht() to ath_rc_get_highest_rix() Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 13/21] ath9k: remove unnecessary IEEE80211_TX_CTL_NO_ACK checks Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 14/21] mac80211: make minstrel/pid RC use ieee80211_is_data(fc) Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 15/21] iwlwifi: " Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 20:33 ` [ath9k-devel] " reinette chatre
2009-07-15 20:33 ` reinette chatre
2009-07-15 0:14 ` [ath9k-devel] [PATCH 16/21] mac80211: add helper for management / no-ack frame rate decision Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 20:33 ` [ath9k-devel] " reinette chatre
2009-07-15 20:33 ` reinette chatre
2009-07-16 17:00 ` [ath9k-devel] " Luis R. Rodriguez
2009-07-16 17:00 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 17/21] ath9k: remove rate control wraper Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 18/21] ath9k: Remove dead code in rate control Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 19/21] ath9k: Remove unused members from rate control structure Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 20/21] ath9k: Use probe interval instead of rssi reduce interval Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
2009-07-15 0:14 ` [ath9k-devel] [PATCH 21/21] ath9k: Nuke struct ath_tx_ratectrl_state Luis R. Rodriguez
2009-07-15 0:14 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090715145601.GA5682@mosca \
--to=lrodriguez@atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.