[Qemu-devel] Re: [PATCH 0/4] qemu-iotests: Backing file tests

[Christoph Hellwig <hch@lst.de>]

On Thu, Jul 16, 2009 at 12:08:56PM +0200, Kevin Wolf wrote:
> This series adds some patches for backing files to qemu-iotests. It is meant to
> be applied on top of the recently posted patch introducing test 016.

Thanks, I've put all the patches in.

It would be good if we could get Akkarit ASAP as I really don't want
to keep failing tests for the major formats (really just raw and qcow2)
around for more than nessecary.

I wonder if we'll eventually have to add an xfail mechanism for the
other formats as we can't really rely on them being maintained and
getting fixed ASAP.

These patches also bring two issues up I'll want to eventually fixed:

 - the use of the $(( )) synatx is a bashism.  We'll either need to
   switch to officially requiring bash and using #!/bin/bash in the
   first line or switch to use Posix sh synax using let or the expr
   helper.  Given how nice $(( )) is I'd lean towards the former.
 - We'll probably want to introduce standard $TEST_BACKING_IMG and
   similar variables aswell as shell functions for creating and dealing
   with them now that they get more common.  Same for the .orig stuff
   we use when creating compressed images.

none of that is really ugent, though.