* [PATCH 7/8] rt2x00: Use %pM conversion specifier
@ 2009-07-16 9:00 Tobias Klauser
2009-07-16 20:27 ` Ivo van Doorn
0 siblings, 1 reply; 4+ messages in thread
From: Tobias Klauser @ 2009-07-16 9:00 UTC (permalink / raw)
To: linville, IvDoorn, netdev, linux-wireless, users; +Cc: Tobias Klauser
Use the %pM conversion specifier for printk instead of print_mac.
Signed-off-by: Tobias Klauser <klto@zhaw.ch>
---
drivers/net/wireless/rt2x00/rt2800usb.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
index 3756166..da84afb 100644
--- a/drivers/net/wireless/rt2x00/rt2800usb.c
+++ b/drivers/net/wireless/rt2x00/rt2800usb.c
@@ -2224,10 +2224,8 @@ static int rt2800usb_validate_eeprom(struct rt2x00_dev *rt2x00dev)
*/
mac = rt2x00_eeprom_addr(rt2x00dev, EEPROM_MAC_ADDR_0);
if (!is_valid_ether_addr(mac)) {
- DECLARE_MAC_BUF(macbuf);
-
random_ether_addr(mac);
- EEPROM(rt2x00dev, "MAC: %s\n", print_mac(macbuf, mac));
+ EEPROM(rt2x00dev, "MAC: %pM\n", mac);
}
rt2x00_eeprom_read(rt2x00dev, EEPROM_ANTENNA, &word);
--
1.6.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 7/8] rt2x00: Use %pM conversion specifier
2009-07-16 9:00 [PATCH 7/8] rt2x00: Use %pM conversion specifier Tobias Klauser
@ 2009-07-16 20:27 ` Ivo van Doorn
2009-07-16 20:35 ` Luis R. Rodriguez
0 siblings, 1 reply; 4+ messages in thread
From: Ivo van Doorn @ 2009-07-16 20:27 UTC (permalink / raw)
To: Tobias Klauser; +Cc: linville, netdev, linux-wireless, users
On Thursday 16 July 2009, Tobias Klauser wrote:
> Use the %pM conversion specifier for printk instead of print_mac.
>
> Signed-off-by: Tobias Klauser <klto@zhaw.ch>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800usb.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
> index 3756166..da84afb 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -2224,10 +2224,8 @@ static int rt2800usb_validate_eeprom(struct rt2x00_dev *rt2x00dev)
> */
> mac = rt2x00_eeprom_addr(rt2x00dev, EEPROM_MAC_ADDR_0);
> if (!is_valid_ether_addr(mac)) {
> - DECLARE_MAC_BUF(macbuf);
> -
> random_ether_addr(mac);
> - EEPROM(rt2x00dev, "MAC: %s\n", print_mac(macbuf, mac));
> + EEPROM(rt2x00dev, "MAC: %pM\n", mac);
> }
>
> rt2x00_eeprom_read(rt2x00dev, EEPROM_ANTENNA, &word);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 7/8] rt2x00: Use %pM conversion specifier
@ 2009-07-16 20:35 ` Luis R. Rodriguez
0 siblings, 0 replies; 4+ messages in thread
From: Luis R. Rodriguez @ 2009-07-16 20:35 UTC (permalink / raw)
To: Ivo van Doorn; +Cc: Tobias Klauser, linville, netdev, linux-wireless, users
On Thu, Jul 16, 2009 at 1:27 PM, Ivo van Doorn<ivdoorn@gmail.com> wrote:
> On Thursday 16 July 2009, Tobias Klauser wrote:
>> Use the %pM conversion specifier for printk instead of print_mac.
>>
>> Signed-off-by: Tobias Klauser <klto@zhaw.ch>
>
> Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
Johannes already has a patch for this posted which takes care of all of these.
http://marc.info/?l=linux-wireless&m=124767211929848&w=2
Luis
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 7/8] rt2x00: Use %pM conversion specifier
@ 2009-07-16 20:35 ` Luis R. Rodriguez
0 siblings, 0 replies; 4+ messages in thread
From: Luis R. Rodriguez @ 2009-07-16 20:35 UTC (permalink / raw)
To: Ivo van Doorn
Cc: Tobias Klauser, linville-2XuSBdqkA4R54TAoqtyWWQ,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H
On Thu, Jul 16, 2009 at 1:27 PM, Ivo van Doorn<ivdoorn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Thursday 16 July 2009, Tobias Klauser wrote:
>> Use the %pM conversion specifier for printk instead of print_mac.
>>
>> Signed-off-by: Tobias Klauser <klto-xXYtEe5Xh1A@public.gmane.org>
>
> Acked-by: Ivo van Doorn <IvDoorn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Johannes already has a patch for this posted which takes care of all of these.
http://marc.info/?l=linux-wireless&m=124767211929848&w=2
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-07-16 20:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-16 9:00 [PATCH 7/8] rt2x00: Use %pM conversion specifier Tobias Klauser
2009-07-16 20:27 ` Ivo van Doorn
2009-07-16 20:35 ` Luis R. Rodriguez
2009-07-16 20:35 ` Luis R. Rodriguez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.