From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] change --enable-efiemu to --enable-efiemu64
Date: Sat, 18 Jul 2009 20:32:55 +0200 [thread overview]
Message-ID: <20090718183255.GF8867@thorin> (raw)
In-Reply-To: <d7ead6de0907170915s6727b7eatd2642a9edc94d674@mail.gmail.com>
On Fri, Jul 17, 2009 at 06:15:57PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Like previously discussed efiemu32 can always be compiled hence this patch
This does a few more things than just toggle compile options. Could you
split the patch?
> diff --git a/ChangeLog b/ChangeLog
> index e38ebc5..93c9b00 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,23 @@
> +2009-07-17 Vladimir Serbinenko <phcoder@gmail.com>
> +
> + Always compile efiemu32.o
> +
> + * Makefile.in (enable_efiemu): change to ...
> + (enable_efiemu64): ... this
> + * commands/i386/cpuid.c (grub_i386_cpuid_has_longmode): new function
> + * conf/i386-pc.rmk (efiemu_mod_SOURCES): remove efiemu/i386/coredetect.c
> + (efiemu32.o): always compile this target
> + * configure.ac: change enable-efiemu to enable-efiemu64.
> + Restrict efiemu compilation to i386-pc
> + * efiemu/i386/coredetect.c: remove file
> + * efiemu/main.c (grub_efiemu_load_file): return error correctly
> + (grub_efiemu_autocore): fallback to efiemu32.o on amd64 if efiemu64.o
> + is unavailable
> + * efiemu/mm.c (grub_efiemu_mmap_init): correct comment style
> + * include/grub/efiemu/efiemu.h (grub_efiemu_get_default_core_name):
> + remove
> + * include/grub/i386/cpuid.h: new file
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2009-07-18 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 16:15 [PATCH] change --enable-efiemu to --enable-efiemu64 Vladimir 'phcoder' Serbinenko
2009-07-18 18:32 ` Robert Millan [this message]
2009-07-18 21:59 ` Pavel Roskin
2009-08-28 15:48 ` Vladimir 'phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090718183255.GF8867@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.