From: Robin Holt <holt@sgi.com>
To: Julia Lawall <julia@diku.dk>
Cc: holt@sgi.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/6] drivers/misc/sgi-xp: convert nested
Date: Sat, 18 Jul 2009 23:20:00 +0000 [thread overview]
Message-ID: <20090718232000.GB7426@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0907181723360.26792@ask.diku.dk>
On Sat, Jul 18, 2009 at 05:23:57PM +0200, Julia Lawall wrote:
> - spin_lock_irqsave(&part_uv->flags_lock, irq_flags);
> + spin_lock(&part_uv->flags_lock);
> part_uv->flags &= ~XPC_P_CACHED_ACTIVATE_GRU_MQ_DESC_UV;
Please do not change this.
I think this is a false positive to a automated script. We are not
comparing against the processors irq flags, but rather against the
partitions flags. Note above the difference between irq_flags and
part_uv->flags.
Maybe I misunderstand your point in this patch.
Robin
WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Julia Lawall <julia@diku.dk>
Cc: holt@sgi.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/6] drivers/misc/sgi-xp: convert nested spin_lock_irqsave to spin_lock
Date: Sat, 18 Jul 2009 18:20:00 -0500 [thread overview]
Message-ID: <20090718232000.GB7426@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0907181723360.26792@ask.diku.dk>
On Sat, Jul 18, 2009 at 05:23:57PM +0200, Julia Lawall wrote:
> - spin_lock_irqsave(&part_uv->flags_lock, irq_flags);
> + spin_lock(&part_uv->flags_lock);
> part_uv->flags &= ~XPC_P_CACHED_ACTIVATE_GRU_MQ_DESC_UV;
Please do not change this.
I think this is a false positive to a automated script. We are not
comparing against the processors irq flags, but rather against the
partitions flags. Note above the difference between irq_flags and
part_uv->flags.
Maybe I misunderstand your point in this patch.
Robin
next prev parent reply other threads:[~2009-07-18 23:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-18 15:23 [PATCH 3/6] drivers/misc/sgi-xp: convert nested spin_lock_irqsave Julia Lawall
2009-07-18 15:23 ` [PATCH 3/6] drivers/misc/sgi-xp: convert nested spin_lock_irqsave to spin_lock Julia Lawall
2009-07-18 23:20 ` Robin Holt [this message]
2009-07-18 23:20 ` Robin Holt
2009-07-18 23:33 ` [PATCH 3/6] drivers/misc/sgi-xp: convert nested Robin Holt
2009-07-18 23:33 ` [PATCH 3/6] drivers/misc/sgi-xp: convert nested spin_lock_irqsave to spin_lock Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090718232000.GB7426@sgi.com \
--to=holt@sgi.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.