[PATCH] dm-raid1: wake the thread after adding bios to the queue

[PATCH] dm-raid1: wake the thread after adding bios to the queue

[Mikulas Patocka]

Hi. I found this bug when reading dm-raid1.

Mikulas

---

The rule is that whether anything is being added on ms->reads, ms->writes or
ms->failures and the list was empty before, we must call wakeup_mirrord (for
immediate processing) or delayed_wake (for delayed processing).

Otherwise the thread wouldn't be woken up and bio could be sitting on the
list indefinitely.

Recent dm-raid1 clustering patch violate this rule.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
CC: stable@kernel.org

---
 drivers/md/dm-raid1.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6.31-rc2-devel/drivers/md/dm-raid1.c
===================================================================
--- linux-2.6.31-rc2-devel.orig/drivers/md/dm-raid1.c	2009-07-13 15:14:55.000000000 +0200
+++ linux-2.6.31-rc2-devel/drivers/md/dm-raid1.c	2009-07-13 15:15:40.000000000 +0200
@@ -638,6 +638,7 @@ static void do_writes(struct mirror_set 
 		spin_lock_irq(&ms->lock);
 		bio_list_merge(&ms->writes, &requeue);
 		spin_unlock_irq(&ms->lock);
+		delayed_wake(ms);
 	}
 
 	/*

Re: [PATCH] dm-raid1: wake the thread after adding bios to the queue

[Alasdair G Kergon]

On Mon, Jul 13, 2009 at 09:33:06AM -0400, Mikulas Patocka wrote:
> Recent dm-raid1 clustering patch violate this rule.
 
Upstream git commit id?

Alasdair

Re: dm-raid1: wake the thread after adding bios to the queue

[Mike Snitzer]

On Mon, Jul 20 2009 at  8:52am -0400,
Alasdair G Kergon <agk@redhat.com> wrote:

> On Mon, Jul 13, 2009 at 09:33:06AM -0400, Mikulas Patocka wrote:
> > Recent dm-raid1 clustering patch violate this rule.
>  
> Upstream git commit id?

7513c2a761d69d2a93f17146b3563527d3618ba0