[PATCH] stubdom: use TARGET_PAGE_SIZE

[PATCH] stubdom: use TARGET_PAGE_SIZE

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]


Hi!

Attached patch makes xenfbfront using TARGET_PAGE_SIZE instead of PAGE_SIZE.
Found by build error on NetBSD (PAGE_SIZE isn't defined, but TARGET_PAGE_SIZE 
is).

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: xen_ioemu_xenfbfront.diff --]
[-- Type: text/x-diff, Size: 360 bytes --]

diff --git a/xenfbfront.c b/xenfbfront.c
index 32761a5..743c065 100644
--- a/xenfbfront.c
+++ b/xenfbfront.c
@@ -28,6 +28,11 @@ static DisplayChangeListener *dcl;
 
 extern uint32_t vga_ram_size;
 
+#ifdef CONFIG_STUBDOM
+#undef PAGE_SIZE
+#define PAGE_SIZE TARGET_PAGE_SIZE
+#endif
+
 int xenfb_connect_vkbd(const char *path)
 {
     kbd_path = strdup(path);

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] stubdom: use TARGET_PAGE_SIZE

[Stefano Stabellini]

> diff --git a/xenfbfront.c b/xenfbfront.c
> index 32761a5..743c065 100644
> --- a/xenfbfront.c
> +++ b/xenfbfront.c
> @@ -28,6 +28,11 @@ static DisplayChangeListener *dcl;
>  
>  extern uint32_t vga_ram_size;
>  
> +#ifdef CONFIG_STUBDOM
> +#undef PAGE_SIZE
> +#define PAGE_SIZE TARGET_PAGE_SIZE
> +#endif
> +
>  int xenfb_connect_vkbd(const char *path)
>  {
>      kbd_path = strdup(path);
> 
> On Mon, 20 Jul 2009, Christoph Egger wrote:
> 

I think the correct way to fix this is to substitute all the occurrences
of PAGE_SIZE with XC_PAGE_SIZE in xenfbfront.c.

Re: [PATCH] stubdom: use TARGET_PAGE_SIZE

[Ian Jackson]

Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] stubdom: use TARGET_PAGE_SIZE"):
> [Christoph Egger]
> > +#undef PAGE_SIZE
> > +#define PAGE_SIZE TARGET_PAGE_SIZE
> > +#endif
> 
> I think the correct way to fix this is to substitute all the occurrences
> of PAGE_SIZE with XC_PAGE_SIZE in xenfbfront.c.

Thanks for the suggestion.  I agree so I've done that.

Ian.