Re: [PATCH] tools: use C99 __VA_ARGS__

[Christoph Egger <Christoph.Egger@amd.com>]

On Tuesday 21 July 2009 15:26:14 Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] tools: use C99 __VA_ARGS__"):
> > Attached patch switches tools to consistently use C99 __VA_ARGS__.
>
> What is the benefit of this ?

Consistency in the whole tree in combination with two other patches
(xen-kernel and minios) which I have not yet submitted.

> Xen requires GCC and the GCC variable 
> argument list extension has been around forever,

That's not a reason to stick on old things.

> so it doesn't seem to aid portability.

No, not in this case.

But the other patch for the xen-kernel touches
the public headers.
AFAIK the public headers should follow the standard.

> The GCC syntax is considerably prettier than the C99 one.

This is subjective.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632