From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: Trilok Soni <soni.trilok-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>,
Arve Hj?nnev?g <arve-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
kernel list
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Brian Swetland <swetland-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Joonyoung Shim
<jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
t.fujak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Subject: Re: Threaded interrupts for synaptic touchscreen in HTC dream
Date: Tue, 21 Jul 2009 09:04:37 -0700 [thread overview]
Message-ID: <20090721160436.GD4352@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <20090721124933.GA5668-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
On Tue, Jul 21, 2009 at 01:49:33PM +0100, Mark Brown wrote:
> On Tue, Jul 21, 2009 at 06:00:07PM +0530, Trilok Soni wrote:
>
> > Hopefully, this thread can give all details about threaded irq discussion.
>
> > http://lkml.org/lkml/2009/2/27/255
>
> Yes, I'm aware of that - I read it at the time. It seemed to peter out
> without any satisfactory solution, unfortunately. There's two separate
> issues here:
>
> - Ordinary devices on interrupt driven or slow buses like I2C. These
> need something along the lines of request_threaded_irq() that's allows
> them to schedule the main IRQ handler outside hardirq context so
> that they can interact with the device. They need to do something in
> hardirq context to disable the interrupt if it's level triggered but
> most of the time the only option they've got is to disable the IRQ
> and reenable it when the worker thread is done. This is the issue
> here.
>
> My immediate thought when I noticed this was that we should probably
> fix request_threaded_irq() so that it's useful for them; I'd been
> intending to do some digging and try to understand why it is
> currently implemented as it is.
>
> - Multi-function devices like the twl4030 which have an interrupt
> controller on them and would like to expose that interrupt controller
> via the generic IRQ subsystem. This was a large part of the
> discussion in the thread above is a much trickier problem.
>
> I've added the folks from Samsung posting the MELFAS MCS-5000 driver to
> the thread since they're running into the same issue.
>
Let's also add Thomas and David since I believe they worked on the
feature.
>From my part I would like to have the threaded IRQ available to all
drivers since it seens to be hanlding driver shutdown cleanly and
without races which is a big plus for me since very few drivers get it
right.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Trilok Soni <soni.trilok@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Arve Hj?nnev?g <arve@android.com>,
kernel list <linux-kernel@vger.kernel.org>,
Brian Swetland <swetland@google.com>,
linux-input@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
linux-i2c@vger.kernel.org,
Joonyoung Shim <jy0922.shim@samsung.com>,
m.szyprowski@samsung.com, t.fujak@samsung.com,
kyungmin.park@samsung.com, tglx@linutronix.de,
David Brownell <david-b@pacbell.net>
Subject: Re: Threaded interrupts for synaptic touchscreen in HTC dream
Date: Tue, 21 Jul 2009 09:04:37 -0700 [thread overview]
Message-ID: <20090721160436.GD4352@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <20090721124933.GA5668@rakim.wolfsonmicro.main>
On Tue, Jul 21, 2009 at 01:49:33PM +0100, Mark Brown wrote:
> On Tue, Jul 21, 2009 at 06:00:07PM +0530, Trilok Soni wrote:
>
> > Hopefully, this thread can give all details about threaded irq discussion.
>
> > http://lkml.org/lkml/2009/2/27/255
>
> Yes, I'm aware of that - I read it at the time. It seemed to peter out
> without any satisfactory solution, unfortunately. There's two separate
> issues here:
>
> - Ordinary devices on interrupt driven or slow buses like I2C. These
> need something along the lines of request_threaded_irq() that's allows
> them to schedule the main IRQ handler outside hardirq context so
> that they can interact with the device. They need to do something in
> hardirq context to disable the interrupt if it's level triggered but
> most of the time the only option they've got is to disable the IRQ
> and reenable it when the worker thread is done. This is the issue
> here.
>
> My immediate thought when I noticed this was that we should probably
> fix request_threaded_irq() so that it's useful for them; I'd been
> intending to do some digging and try to understand why it is
> currently implemented as it is.
>
> - Multi-function devices like the twl4030 which have an interrupt
> controller on them and would like to expose that interrupt controller
> via the generic IRQ subsystem. This was a large part of the
> discussion in the thread above is a much trickier problem.
>
> I've added the folks from Samsung posting the MELFAS MCS-5000 driver to
> the thread since they're running into the same issue.
>
Let's also add Thomas and David since I believe they worked on the
feature.
>From my part I would like to have the threaded IRQ available to all
drivers since it seens to be hanlding driver shutdown cleanly and
without races which is a big plus for me since very few drivers get it
right.
--
Dmitry
next prev parent reply other threads:[~2009-07-21 16:04 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 10:06 Support for synaptic touchscreen in HTC dream Pavel Machek
2009-07-14 10:20 ` Trilok Soni
2009-07-14 10:20 ` Trilok Soni
[not found] ` <5d5443650907140320w334864f4uc1ee13ed32fdb874-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-15 13:36 ` Pavel Machek
2009-07-15 13:36 ` Pavel Machek
[not found] ` <20090715133627.GA2538-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2009-07-15 17:33 ` Trilok Soni
2009-07-15 17:33 ` Trilok Soni
[not found] ` <5d5443650907151033w36008b71pe4b32bcea9489b75-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-21 10:21 ` Pavel Machek
2009-07-21 10:21 ` Pavel Machek
2009-07-21 10:34 ` Trilok Soni
2009-07-21 10:34 ` Trilok Soni
[not found] ` <5d5443650907210334k3f562cebsc665511a161c8639-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-08-08 13:40 ` Synaptics touchscreen for HTC Dream: check that smbus is available Pavel Machek
2009-08-08 13:40 ` Pavel Machek
[not found] ` <20090808134049.GA13083-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2009-08-17 23:47 ` Andrew Morton
2009-08-17 23:47 ` Andrew Morton
[not found] ` <20090817164759.43c39f2d.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-08-21 14:23 ` Pavel Machek
2009-08-21 14:23 ` Pavel Machek
2009-07-21 10:59 ` Threaded interrupts for synaptic touchscreen in HTC dream Pavel Machek
[not found] ` <20090721105924.GK4133-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2009-07-21 11:36 ` Mark Brown
2009-07-21 11:36 ` Mark Brown
[not found] ` <20090721113642.GC13286-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2009-07-21 12:18 ` Trilok Soni
2009-07-21 12:18 ` Trilok Soni
2009-07-21 12:30 ` Trilok Soni
2009-07-21 12:30 ` Trilok Soni
2009-07-21 12:49 ` Mark Brown
[not found] ` <20090721124933.GA5668-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2009-07-21 16:04 ` Dmitry Torokhov [this message]
2009-07-21 16:04 ` Dmitry Torokhov
[not found] ` <20090721160436.GD4352-wUGeVx6es1+Q2O5dskk9LyLysJ1jNyTM@public.gmane.org>
2009-07-21 20:30 ` Thomas Gleixner
2009-07-21 20:30 ` Thomas Gleixner
2009-07-21 20:58 ` Dmitry Torokhov
2009-07-21 21:48 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0907212225030.2813-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-07-21 22:25 ` Mark Brown
2009-07-21 22:25 ` Mark Brown
[not found] ` <20090721222547.GA1948-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2009-07-22 10:44 ` Thomas Gleixner
2009-07-22 10:44 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0907221022190.2813-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-07-22 12:18 ` Mark Brown
2009-07-22 12:18 ` Mark Brown
2009-07-22 12:58 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0907221427380.2813-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-07-22 13:30 ` Peter Zijlstra
2009-07-22 13:30 ` Peter Zijlstra
2009-07-22 14:18 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0907221615480.2813-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-07-22 14:32 ` Mark Brown
2009-07-22 14:32 ` Mark Brown
[not found] ` <20090722143211.GB29404-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2009-07-22 14:52 ` Thomas Gleixner
2009-07-22 14:52 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0907221645240.2813-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-07-22 14:56 ` Mark Brown
2009-07-22 14:56 ` Mark Brown
2009-07-22 15:15 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0907221715260.2813-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-07-22 15:56 ` Mark Brown
2009-07-22 15:56 ` Mark Brown
2009-07-22 16:57 ` David Brownell
2009-07-22 16:57 ` David Brownell
[not found] ` <200907220957.16499.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-07-22 21:04 ` Thomas Gleixner
2009-07-22 21:04 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0907222226270.2813-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-07-22 21:57 ` Arve Hjønnevåg
2009-07-22 21:57 ` Arve Hjønnevåg
[not found] ` <d6200be20907221457r4e2f6d29g57146586fd13776a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-22 22:15 ` David Brownell
2009-07-22 22:15 ` David Brownell
2009-07-22 23:30 ` Arve Hjønnevåg
2009-07-22 23:30 ` Arve Hjønnevåg
2009-07-22 22:09 ` David Brownell
2009-07-23 4:43 ` Dmitry Torokhov
2009-07-22 13:31 ` Mark Brown
2009-07-22 13:31 ` Mark Brown
2009-07-22 17:04 ` David Brownell
2009-07-22 17:08 ` Mark Brown
2009-07-22 16:04 ` Dmitry Torokhov
[not found] ` <20090722155811.GA2775-wUGeVx6es1+Q2O5dskk9LyLysJ1jNyTM@public.gmane.org>
2009-07-22 16:40 ` Thomas Gleixner
2009-07-22 16:40 ` Thomas Gleixner
2009-07-22 16:57 ` Mark Brown
[not found] ` <alpine.LFD.2.00.0907221830410.2813-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-07-22 17:08 ` Dmitry Torokhov
2009-07-22 17:08 ` Dmitry Torokhov
2009-07-22 17:13 ` David Brownell
2009-07-22 17:13 ` David Brownell
2009-07-22 16:51 ` David Brownell
2009-07-22 16:39 ` David Brownell
2009-07-22 16:39 ` David Brownell
[not found] ` <200907220939.33399.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-07-22 16:43 ` Thomas Gleixner
2009-07-22 16:43 ` Thomas Gleixner
2009-07-22 17:34 ` David Brownell
2009-07-22 16:50 ` Mark Brown
2009-07-22 16:50 ` Mark Brown
2009-07-22 17:41 ` David Brownell
2009-07-21 20:43 ` Daniel Ribeiro
2009-07-21 20:43 ` Daniel Ribeiro
2009-07-21 12:30 ` Mark Brown
2009-07-23 14:55 ` Pavel Machek
2009-07-15 21:33 ` Support " Arve Hjønnevåg
2009-07-15 21:33 ` Arve Hjønnevåg
2009-07-21 10:40 ` Pavel Machek
2009-07-14 17:52 ` Dmitry Torokhov
2009-07-15 13:48 ` Pavel Machek
2009-07-15 15:27 ` Dmitry Torokhov
2009-07-15 15:33 ` Brian Swetland
2009-07-15 17:26 ` Trilok Soni
2009-07-15 17:26 ` Trilok Soni
2009-07-15 18:43 ` Arve Hjønnevåg
2009-07-15 20:24 ` Arve Hjønnevåg
2009-07-15 20:24 ` Arve Hjønnevåg
2009-07-15 13:50 ` Pavel Machek
2009-08-08 14:02 ` HTC Dream for staging: small cleanups [was Re: Support for synaptic touchscreen in HTC dream] Pavel Machek
2009-07-14 20:25 ` Support for synaptic touchscreen in HTC dream Andreas Mohr
2009-07-14 20:33 ` Andreas Mohr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090721160436.GD4352@dtor-d630.eng.vmware.com \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=akpm-3NddpPZAyC0@public.gmane.org \
--cc=arve-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=soni.trilok-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=swetland-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=t.fujak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.