Re: [PATCH] Build system improvement

[Robert Millan <rmh@aybabtu.com>]

On Wed, Jul 22, 2009 at 12:14:54PM -0400, Pavel Roskin wrote:
> On Wed, 2009-07-22 at 14:41 +0200, Felix Zielcke wrote:
> 
> > > [0] http://lists.gnu.org/archive/html/grub-devel/2009-05/msg00009.html
> > 
> > So what's now with it?
> > Marco can you at least say something about it?
> > It would be very nice if the warnings would be more visible by default.
> > Probable we can't ever use -Werror because different compilers produce
> > different warnings etc.
> > For example gentoo's gcc with his trampoline patch.
> 
> I don't see any warnings in any configuration, unless more warning flags
> are added (e.g. -Wconversion, which is very noisy).
> 
> We can use -Werror by default, but make it very easy to disable.  For
> instance, we could have a configure option --disable-strict-warnings.
> 
> GRUB is a bootloader; we don't want anyone's system to become unbootable
> because something was miscompiled.  Requiring an extra step to disable
> warnings would tell users to be more careful.

I completely agree with this (both things).

Except, I'd call it --disable-werror, I think it's clearer (and I vaguely
recall other projects using this flag).

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."