From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] UUID support for UFS
Date: Wed, 22 Jul 2009 19:44:36 +0200 [thread overview]
Message-ID: <20090722174436.GK8706@thorin> (raw)
In-Reply-To: <d7ead6de0907211445r207a4057p9b282741e4d8737@mail.gmail.com>
On Tue, Jul 21, 2009 at 11:45:59PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> This change would allow to produce a code which is cleaner, easier to
> read and understand. However I'm opposed to modifying printf function
> for it. Instead we could just define somewhere:
> GRUB_PRIx32 "%x"
> #ifdef LONG_SIZEOF == 8
> GRUB_PRIx64 "%lx"
> #else
> GRUB_PRIx64 "%llx"
> #endif
This is unnecessary. We defined the data as grub_uint32_t, so just dropping
the 'l' and the `unsigned long' casts should do.
As Pavel said, if we ever support a platform where sizeof(int) != 4, we have
more serious problems to worry about.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2009-07-22 17:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 13:03 [PATCH] UUID support for UFS Vladimir 'phcoder' Serbinenko
2009-07-21 17:14 ` Pavel Roskin
2009-07-21 20:01 ` Vladimir 'phcoder' Serbinenko
2009-07-21 18:46 ` Javier Martín
2009-07-21 21:31 ` Pavel Roskin
2009-07-21 21:45 ` Vladimir 'phcoder' Serbinenko
2009-07-21 22:05 ` Pavel Roskin
2009-07-21 20:14 ` Javier Martín
2009-07-21 22:37 ` Pavel Roskin
2009-07-21 21:34 ` Javier Martín
2009-07-22 0:20 ` Pavel Roskin
2009-07-22 17:47 ` Robert Millan
2009-07-22 18:02 ` Javier Martín
2009-07-22 17:44 ` Robert Millan [this message]
2009-07-21 20:04 ` Pavel Roskin
2009-07-22 17:40 ` Robert Millan
2009-07-22 17:47 ` Vladimir 'phcoder' Serbinenko
2009-07-22 18:01 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090722174436.GK8706@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.