From: "Todd T. Fries" <todd@fries.net>
To: Andi Kleen <andi@firstfloor.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Allow setting qemu process name
Date: Thu, 23 Jul 2009 06:47:16 -0500 [thread overview]
Message-ID: <20090723114715.GA826@fries.net> (raw)
In-Reply-To: <20090701093251.GA12447@basil.fritz.box>
Penned by Andi Kleen on 20090701 11:32.52, we have:
|
| [this is a port of a old KVM userland patch I had; Avi back then suggested to
| submit it to qemu]
|
| Set the Linux process name to the name argument specified with "-name". I find
| this useful to see which guests are taking CPU time in top.
|
| This doesn't affect ps, which checks argv[0], but rewriting the
| environment uses much more code, so I only used this simple way.
|
| Signed-off-by: Andi Kleen <ak@linux.intel.com>
|
| diff --git a/vl.c b/vl.c
| index 7b7489c..584c48e 100644
| --- a/vl.c
| +++ b/vl.c
| @@ -68,6 +68,7 @@
| #include <pty.h>
| #include <malloc.h>
| #include <linux/rtc.h>
| +#include <sys/prctl.h>
|
| /* For the benefit of older linux systems which don't supply it,
| we use a local copy of hpet.h. */
| @@ -526,6 +527,19 @@ void hw_error(const char *fmt, ...)
| va_end(ap);
| abort();
| }
| +
| +static void set_proc_name(const char *prefix, const char *s)
| +{
| +#ifdef __linux__
| + char name[16];
| + if (!s)
| + return;
| + /* Could rewrite argv[0] too, but that's a bit more complicated.
| + This simple way is enough for `top'. */
| + snprintf(name, sizeof name, "%s-%.10s", prefix, s);
| + prctl(PR_SET_NAME, name);
#elif defined(__OpenBSD__)
if (!s)
setproctitle("%s-%.10s", prefix, s);
| +#endif
| +}
|
| /***************/
| /* ballooning */
| @@ -6008,11 +6022,15 @@ int main(int argc, char **argv, char **envp)
| if (kvm_enabled()) {
| int ret;
|
| + set_proc_name("kvm", qemu_name);
| +
| ret = kvm_init(smp_cpus);
| if (ret < 0) {
| fprintf(stderr, "failed to initialize KVM\n");
| exit(1);
| }
| + } else {
| + set_proc_name("qemu", qemu_name);
| }
|
| if (monitor_device) {
| --
| ak@linux.intel.com -- Speaking for myself only.
|
--
Todd Fries .. todd@fries.net
_____________________________________________
| \ 1.636.410.0632 (voice)
| Free Daemon Consulting, LLC \ 1.405.227.9094 (voice)
| http://FreeDaemonConsulting.com \ 1.866.792.3418 (FAX)
| "..in support of free software solutions." \ sip:freedaemon@ekiga.net
| \ sip:4052279094@ekiga.net
\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\
37E7 D3EB 74D0 8D66 A68D B866 0326 204E 3F42 004A
http://todd.fries.net/pgp.txt
next prev parent reply other threads:[~2009-07-23 11:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 9:32 [Qemu-devel] [PATCH] Allow setting qemu process name Andi Kleen
2009-07-01 13:29 ` Anthony Liguori
2009-07-01 13:43 ` Andi Kleen
2009-07-01 13:57 ` Anthony Liguori
2009-07-01 14:06 ` Andi Kleen
2009-07-01 15:08 ` Avi Kivity
2009-07-01 16:27 ` Jamie Lokier
2009-07-01 15:07 ` Avi Kivity
2009-07-01 16:19 ` Luiz Capitulino
2009-07-01 16:27 ` Avi Kivity
2009-07-01 16:34 ` Luiz Capitulino
2009-07-01 16:43 ` Avi Kivity
2009-07-01 17:02 ` Jamie Lokier
2009-07-01 17:43 ` Stefan Weil
2009-07-23 11:47 ` Todd T. Fries [this message]
2009-07-23 12:01 ` Andi Kleen
2009-07-23 12:58 ` Todd T. Fries
2009-07-23 14:30 ` Andi Kleen
2009-07-24 9:34 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090723114715.GA826@fries.net \
--to=todd@fries.net \
--cc=andi@firstfloor.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.