From: Anthony Liguori <anthony@codemonkey.ws>
To: Andi Kleen <andi@firstfloor.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Allow setting qemu process name
Date: Wed, 01 Jul 2009 08:29:22 -0500 [thread overview]
Message-ID: <4A4B64B2.3040106@codemonkey.ws> (raw)
In-Reply-To: <20090701093251.GA12447@basil.fritz.box>
Andi Kleen wrote:
> [this is a port of a old KVM userland patch I had; Avi back then suggested to
> submit it to qemu]
>
> Set the Linux process name to the name argument specified with "-name". I find
> this useful to see which guests are taking CPU time in top.
>
This is not a bad idea but it has to be optional and non-default. Maybe
a new command line option?
> /***************/
> /* ballooning */
> @@ -6008,11 +6022,15 @@ int main(int argc, char **argv, char **envp)
> if (kvm_enabled()) {
> int ret;
>
> + set_proc_name("kvm", qemu_name);
> +
> ret = kvm_init(smp_cpus);
> if (ret < 0) {
> fprintf(stderr, "failed to initialize KVM\n");
> exit(1);
> }
> + } else {
> + set_proc_name("qemu", qemu_name);
> }
I'd rather see qemu be the prefix unconditionally.
Regards,
Anthony Liguori
>
> if (monitor_device) {
>
next prev parent reply other threads:[~2009-07-01 13:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 9:32 [Qemu-devel] [PATCH] Allow setting qemu process name Andi Kleen
2009-07-01 13:29 ` Anthony Liguori [this message]
2009-07-01 13:43 ` Andi Kleen
2009-07-01 13:57 ` Anthony Liguori
2009-07-01 14:06 ` Andi Kleen
2009-07-01 15:08 ` Avi Kivity
2009-07-01 16:27 ` Jamie Lokier
2009-07-01 15:07 ` Avi Kivity
2009-07-01 16:19 ` Luiz Capitulino
2009-07-01 16:27 ` Avi Kivity
2009-07-01 16:34 ` Luiz Capitulino
2009-07-01 16:43 ` Avi Kivity
2009-07-01 17:02 ` Jamie Lokier
2009-07-01 17:43 ` Stefan Weil
2009-07-23 11:47 ` Todd T. Fries
2009-07-23 12:01 ` Andi Kleen
2009-07-23 12:58 ` Todd T. Fries
2009-07-23 14:30 ` Andi Kleen
2009-07-24 9:34 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4B64B2.3040106@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=andi@firstfloor.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.