From: Johannes Weiner <hannes@cmpxchg.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux-foundation.org>,
kosaki.motohiro@jp.fujitsu.com, maximlevitsky@gmail.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Lee.Schermerhorn@hp.com, penberg@cs.helsinki.fi,
jirislaby@gmail.com
Subject: Re: [PATCH] mm: Warn once when a page is freed with PG_mlocked set V2
Date: Fri, 24 Jul 2009 14:00:04 +0200 [thread overview]
Message-ID: <20090724120004.GA2874@cmpxchg.org> (raw)
In-Reply-To: <20090724103656.GA18074@csn.ul.ie>
On Fri, Jul 24, 2009 at 11:36:56AM +0100, Mel Gorman wrote:
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index b8283e8..d3d0707 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -488,6 +488,11 @@ static inline void __free_one_page(struct page *page,
> */
> static inline void free_page_mlock(struct page *page)
> {
> + WARN_ONCE(1, KERN_WARNING
> + "Page flag mlocked set for process %s at pfn:%05lx\n"
> + "page:%p flags:%#lx\n",
> + current->comm, page_to_pfn(page),
> + page, page->flags|__PG_MLOCKED);
I don't think printing page->flags is all too useful after they have
been cleared by free_pages_check().
But it's probably a reasonable trade-off for not having it in the
fast-path.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux-foundation.org>,
kosaki.motohiro@jp.fujitsu.com, maximlevitsky@gmail.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Lee.Schermerhorn@hp.com, penberg@cs.helsinki.fi,
jirislaby@gmail.com
Subject: Re: [PATCH] mm: Warn once when a page is freed with PG_mlocked set V2
Date: Fri, 24 Jul 2009 14:00:04 +0200 [thread overview]
Message-ID: <20090724120004.GA2874@cmpxchg.org> (raw)
In-Reply-To: <20090724103656.GA18074@csn.ul.ie>
On Fri, Jul 24, 2009 at 11:36:56AM +0100, Mel Gorman wrote:
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index b8283e8..d3d0707 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -488,6 +488,11 @@ static inline void __free_one_page(struct page *page,
> */
> static inline void free_page_mlock(struct page *page)
> {
> + WARN_ONCE(1, KERN_WARNING
> + "Page flag mlocked set for process %s at pfn:%05lx\n"
> + "page:%p flags:%#lx\n",
> + current->comm, page_to_pfn(page),
> + page, page->flags|__PG_MLOCKED);
I don't think printing page->flags is all too useful after they have
been cleared by free_pages_check().
But it's probably a reasonable trade-off for not having it in the
fast-path.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-07-24 12:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 12:58 [PATCH] mm: Warn once when a page is freed with PG_mlocked set V2 Mel Gorman
2009-07-15 12:58 ` Mel Gorman
2009-07-15 14:31 ` Christoph Lameter
2009-07-15 14:31 ` Christoph Lameter
2009-07-15 22:04 ` Johannes Weiner
2009-07-15 22:04 ` Johannes Weiner
2009-07-16 7:37 ` KOSAKI Motohiro
2009-07-16 7:37 ` KOSAKI Motohiro
2009-07-16 13:54 ` Christoph Lameter
2009-07-16 13:54 ` Christoph Lameter
2009-07-16 16:01 ` Johannes Weiner
2009-07-16 16:01 ` Johannes Weiner
2009-07-17 0:17 ` KOSAKI Motohiro
2009-07-17 0:17 ` KOSAKI Motohiro
2009-07-22 23:06 ` Andrew Morton
2009-07-22 23:06 ` Andrew Morton
2009-07-23 10:29 ` Mel Gorman
2009-07-23 10:29 ` Mel Gorman
2009-07-23 17:23 ` Andrew Morton
2009-07-23 17:23 ` Andrew Morton
2009-07-24 10:36 ` Mel Gorman
2009-07-24 10:36 ` Mel Gorman
2009-07-24 11:31 ` Christoph Lameter
2009-07-24 11:31 ` Christoph Lameter
2009-07-24 12:00 ` Johannes Weiner [this message]
2009-07-24 12:00 ` Johannes Weiner
2009-07-24 12:59 ` Mel Gorman
2009-07-24 12:59 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090724120004.GA2874@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maximlevitsky@gmail.com \
--cc=mel@csn.ul.ie \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.