From: Chris Mason <chris.mason@oracle.com>
To: Felix Blyakher <felixb@sgi.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
xfs mailing list <xfs@oss.sgi.com>,
Christoph Hellwig <hch@infradead.org>,
linux-mm@kvack.org, Olaf Weber <olaf@sgi.com>
Subject: Re: [PATCH] bump up nr_to_write in xfs_vm_writepage
Date: Fri, 24 Jul 2009 08:05:19 -0400 [thread overview]
Message-ID: <20090724120519.GB16192@think> (raw)
In-Reply-To: <7149D747-2769-4559-BAF6-AAD2B6C6C941@sgi.com>
On Fri, Jul 24, 2009 at 12:20:32AM -0500, Felix Blyakher wrote:
>
> On Jul 10, 2009, at 2:12 AM, KOSAKI Motohiro wrote:
>> 3. Current wbc->nr_to_write value is not proper?
>>
>> Current writeback_set_ratelimit() doesn't permit that ratelimit_pages
>> exceed
>> 4M byte. but it is too low restriction for nowadays.
>> (that's my understand. right?)
>>
>> =======================================================
>> void writeback_set_ratelimit(void)
>> {
>> ratelimit_pages = vm_total_pages / (num_online_cpus() * 32);
>> if (ratelimit_pages < 16)
>> ratelimit_pages = 16;
>> if (ratelimit_pages * PAGE_CACHE_SIZE > 4096 * 1024)
>> ratelimit_pages = (4096 * 1024) / PAGE_CACHE_SIZE;
>> }
>> =======================================================
>>
>> Yes, 4M bytes are pretty magical constant. We have three choice
>> A. Remove magical 4M constant simple (a bit danger)
>
> That's will be outside the xfs, and seems like there is no much interest
> from mm people.
>
>> B. Decide high border from IO capability
It is worth pointing out that Jens Axboe is planning on more feedback
controlled knobs as part of pdflush rework.
-chris
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Chris Mason <chris.mason@oracle.com>
To: Felix Blyakher <felixb@sgi.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Eric Sandeen <sandeen@redhat.com>,
xfs mailing list <xfs@oss.sgi.com>,
Christoph Hellwig <hch@infradead.org>,
linux-mm@kvack.org, Olaf Weber <olaf@sgi.com>
Subject: Re: [PATCH] bump up nr_to_write in xfs_vm_writepage
Date: Fri, 24 Jul 2009 08:05:19 -0400 [thread overview]
Message-ID: <20090724120519.GB16192@think> (raw)
In-Reply-To: <7149D747-2769-4559-BAF6-AAD2B6C6C941@sgi.com>
On Fri, Jul 24, 2009 at 12:20:32AM -0500, Felix Blyakher wrote:
>
> On Jul 10, 2009, at 2:12 AM, KOSAKI Motohiro wrote:
>> 3. Current wbc->nr_to_write value is not proper?
>>
>> Current writeback_set_ratelimit() doesn't permit that ratelimit_pages
>> exceed
>> 4M byte. but it is too low restriction for nowadays.
>> (that's my understand. right?)
>>
>> =======================================================
>> void writeback_set_ratelimit(void)
>> {
>> ratelimit_pages = vm_total_pages / (num_online_cpus() * 32);
>> if (ratelimit_pages < 16)
>> ratelimit_pages = 16;
>> if (ratelimit_pages * PAGE_CACHE_SIZE > 4096 * 1024)
>> ratelimit_pages = (4096 * 1024) / PAGE_CACHE_SIZE;
>> }
>> =======================================================
>>
>> Yes, 4M bytes are pretty magical constant. We have three choice
>> A. Remove magical 4M constant simple (a bit danger)
>
> That's will be outside the xfs, and seems like there is no much interest
> from mm people.
>
>> B. Decide high border from IO capability
It is worth pointing out that Jens Axboe is planning on more feedback
controlled knobs as part of pdflush rework.
-chris
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-07-24 12:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 21:29 [PATCH] bump up nr_to_write in xfs_vm_writepage Eric Sandeen
2009-07-02 21:29 ` Eric Sandeen
2009-07-03 23:51 ` Michael Monnerie
2009-07-07 9:07 ` Olaf Weber
2009-07-07 9:07 ` Olaf Weber
2009-07-07 10:19 ` Christoph Hellwig
2009-07-07 10:19 ` Christoph Hellwig
2009-07-07 10:33 ` KOSAKI Motohiro
2009-07-07 10:33 ` KOSAKI Motohiro
2009-07-07 10:44 ` Christoph Hellwig
2009-07-07 10:44 ` Christoph Hellwig
2009-07-09 2:04 ` KOSAKI Motohiro
2009-07-09 2:04 ` KOSAKI Motohiro
2009-07-09 13:01 ` Chris Mason
2009-07-09 13:01 ` Chris Mason
2009-07-10 7:12 ` KOSAKI Motohiro
2009-07-10 7:12 ` KOSAKI Motohiro
2009-07-24 5:20 ` Felix Blyakher
2009-07-24 5:20 ` Felix Blyakher
2009-07-24 5:33 ` KOSAKI Motohiro
2009-07-24 5:33 ` KOSAKI Motohiro
2009-07-24 12:05 ` Chris Mason [this message]
2009-07-24 12:05 ` Chris Mason
2009-07-07 11:37 ` Olaf Weber
2009-07-07 11:37 ` Olaf Weber
2009-07-07 14:46 ` Christoph Hellwig
2009-07-07 14:46 ` Christoph Hellwig
2009-07-07 15:17 ` Chris Mason
2009-07-07 15:17 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090724120519.GB16192@think \
--to=chris.mason@oracle.com \
--cc=felixb@sgi.com \
--cc=hch@infradead.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=olaf@sgi.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.