All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [Fwd: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1]
Date: Sat, 25 Jul 2009 18:45:04 +0200	[thread overview]
Message-ID: <20090725164504.GP12326@thorin> (raw)
In-Reply-To: <1248478502.3510.96.camel@fz.local>

On Sat, Jul 25, 2009 at 01:35:02AM +0200, Felix Zielcke wrote:
> Is this an acceptable fix?
> Though I have the feeling this isn't a proper one.
> 
> -------- Weitergeleitete Nachricht --------
> > Von: Bob Gilligan <gilligan@vyatta.com>
> > Reply-to: Bob Gilligan <gilligan@vyatta.com>, 503344@bugs.debian.org
> > An: submit@bugs.debian.org
> > Betreff: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1
> > Datum: Fri, 24 Oct 2008 16:19:59 -0700
> > 
> > Package: grub-pc
> > Version: 1.96+20080724-10
> > 
> > After installing grub-pc on an IBM x3250 with two 160 GB drives, with 
> > the root filesystem configured using mdadm for RAID-1, grub fails to 
> > boot, printing:
> > 
> > Welcome to GRUB!
> > 
> > error: unknown device fd1
> > Entering rescue mode ...
> > grub rescue>

ISTR we disabled floppy support completely in debian in order to avoid this
kind of trouble (I would disable it in official GRUB as well, but I can
already feel there'd be some opposition :-)).

Anyway, my point is that floppies are too unreliable.  We detect them when
iterating even if they're not readable.  Perhaps we could actually probe them
for read during iteration to solve this.

> > +  grub_errno = GRUB_ERR_NONE;  /* Used as error flag */
> >     device_name = grub_file_get_device_name (name);
> >     if (grub_errno)
> >       return 0;

This looks like a hack.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



  parent reply	other threads:[~2009-07-25 16:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24 23:35 [Fwd: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1] Felix Zielcke
2009-07-25  8:37 ` Vladimir 'phcoder' Serbinenko
2009-07-25  9:31   ` Felix Zielcke
2009-07-25 16:45 ` Robert Millan [this message]
2009-07-25 16:58   ` Felix Zielcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090725164504.GP12326@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.