All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Curt Wohlgemuth <curtw@google.com>,
	ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] Print extent information in debugfs
Date: Mon, 27 Jul 2009 10:34:13 -0400	[thread overview]
Message-ID: <20090727143413.GF17272@mit.edu> (raw)
In-Reply-To: <4A6D1C6A.1000900@redhat.com>

On Sun, Jul 26, 2009 at 10:18:02PM -0500, Eric Sandeen wrote:
> 
> Perhaps a bit late, but I find the "#<extent length>" reporting very
> unintuitive.  Doesn't "#X" usually imply ordering?  How about:
> 
> (0-60 [61b]): 342272-342332, (61-127 [67b,uninit]): 537822-537888
> 
> ... or maybe some other ideas.  IMHO it's all a bit hard to read anyway
> unless it's printed in a table format ala the new filefrag output.

That's a good idea.  I've switched it to use a table format:

Level Entries       Logical          Physical Length Flags
 0/ 0   1/  2     0 -    60  342272 -  342332     61 
 0/ 0   2/  2    61 -   127  537822 -  537888     67 Uninit

and

Level Entries           Logical          Physical Length Flags
 0/ 2   1/  4       1 -  274323   24844           274323
 1/ 2   1/ 84       1 -     387    8458              387
 2/ 2   1/ 84       1 -       1   10242 -   10242      1 
 2/ 2   2/ 84       4 -       4   10245 -   10245      1 
 2/ 2   3/ 84       8 -       8   10249 -   10249      1 

I've also simplified the debugfs stat output so it looks more like the
"BLOCKS" output:

 mtime: 0x4a6d164e:861ee098 -- Sun Jul 26 22:51:58 2009
crtime: 0x4a6d164e:82c08b38 -- Sun Jul 26 22:51:58 2009
Size of extra inode fields: 28
EXTENTS:
(0-60): 342272-342332, (61-127 [uninit]): 537822-537888

Hopefully that's easier for everyone to understand.

							- Ted

      reply	other threads:[~2009-07-27 14:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-23 20:36 [PATCH] Print extent information in debugfs Curt Wohlgemuth
2009-07-27  3:02 ` Theodore Tso
2009-07-27  3:18   ` Eric Sandeen
2009-07-27 14:34     ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090727143413.GF17272@mit.edu \
    --to=tytso@mit.edu \
    --cc=curtw@google.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.