From: Eric Sandeen <sandeen@redhat.com>
To: Theodore Tso <tytso@mit.edu>
Cc: Curt Wohlgemuth <curtw@google.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] Print extent information in debugfs
Date: Sun, 26 Jul 2009 22:18:02 -0500 [thread overview]
Message-ID: <4A6D1C6A.1000900@redhat.com> (raw)
In-Reply-To: <20090727030219.GE17272@mit.edu>
Theodore Tso wrote:
...
> The Extents and Blocks information display redundant information, so
> what I've done is to change the patch so that if the file uses
> extent-based block maps, the Extents information is displayed instead
> of the BLOCKS information, and it is extended to include more
> information, like this:
>
> ...
> atime: 0x4a6d164e:82c08b38 -- Sun Jul 26 22:51:58 2009
> mtime: 0x4a6d164e:861ee098 -- Sun Jul 26 22:51:58 2009
> crtime: 0x4a6d164e:82c08b38 -- Sun Jul 26 22:51:58 2009
> Size of extra inode fields: 28
> EXTENTS:
> (0-60 #61): 342272-342332, (61-127 #67 [uninit]): 537822-537888
Perhaps a bit late, but I find the "#<extent length>" reporting very
unintuitive. Doesn't "#X" usually imply ordering? How about:
(0-60 [61b]): 342272-342332, (61-127 [67b,uninit]): 537822-537888
... or maybe some other ideas. IMHO it's all a bit hard to read anyway
unless it's printed in a table format ala the new filefrag output.
-Eric
next prev parent reply other threads:[~2009-07-27 3:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 20:36 [PATCH] Print extent information in debugfs Curt Wohlgemuth
2009-07-27 3:02 ` Theodore Tso
2009-07-27 3:18 ` Eric Sandeen [this message]
2009-07-27 14:34 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6D1C6A.1000900@redhat.com \
--to=sandeen@redhat.com \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.