From: Glauber Costa <glommer@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] fix broken migration
Date: Mon, 27 Jul 2009 17:18:55 -0300 [thread overview]
Message-ID: <20090727201855.GK4776@poweredge.glommer> (raw)
In-Reply-To: <4A6E009F.8010608@redhat.com>
On Mon, Jul 27, 2009 at 09:31:43PM +0200, Paolo Bonzini wrote:
> On 07/27/2009 08:02 PM, Glauber Costa wrote:
>> If I pass --incoming to the VM, I don't expect the VM to start. I expect it
>> to wait, because I'll be handling it a migration later. However, it does start,
>> which is clearly wrong.
>
> I see now, thanks. I was puzzled by your message, so to speak.
>
> I suppose the best semantics would be to do like
>
> if (autostart && !incoming)
> vm_start ()
>
> in vl.c and add
>
> if (autostart)
> vm_start ()
>
> in the migration-*.c files.
I don't disagree. This is even more explicit about the meaning of each of
the flags.
next prev parent reply other threads:[~2009-07-27 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 20:20 [Qemu-devel] [PATCH] fix broken migration Glauber Costa
2009-07-25 1:37 ` [Qemu-devel] " Paolo Bonzini
2009-07-27 18:02 ` Glauber Costa
2009-07-27 19:31 ` Paolo Bonzini
2009-07-27 20:18 ` Glauber Costa [this message]
2009-07-27 21:08 ` [Qemu-devel] [PATCH] fix migration to not require -S Paolo Bonzini
2009-07-27 21:17 ` [Qemu-devel] [PATCH alternative] fix migration to obey -S Paolo Bonzini
2009-07-27 21:29 ` [Qemu-devel] " Glauber Costa
2009-07-27 21:36 ` Anthony Liguori
2009-07-27 23:15 ` Glauber Costa
2009-07-27 23:13 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090727201855.GK4776@poweredge.glommer \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.