All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] fix broken migration
Date: Sat, 25 Jul 2009 03:37:24 +0200	[thread overview]
Message-ID: <4A6A61D4.1080807@redhat.com> (raw)
In-Reply-To: <1248466823-12707-1-git-send-email-glommer@redhat.com>

On 07/24/2009 10:20 PM, Glauber Costa wrote:
> While fixing migration with -S, commit
> 89befdd1a6b18215153b8976682d57b7d03d5782 broke the rest of us.

With this patch a migrated virtual machine will never be restarted.  If 
you want that, shouldn't you use -S?  But if you really wanted a 
migrated virtual machine to never be restarted, didn't you have a 
problem before my patch as well?

Note that autostart (the variable) is never read except to choose 
whether to do that vm_start; so there can be no collateral effects from 
passing -S.

I don't understand what this patch is trying to achieve (and why).

Paolo

  reply	other threads:[~2009-07-25  1:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24 20:20 [Qemu-devel] [PATCH] fix broken migration Glauber Costa
2009-07-25  1:37 ` Paolo Bonzini [this message]
2009-07-27 18:02   ` [Qemu-devel] " Glauber Costa
2009-07-27 19:31     ` Paolo Bonzini
2009-07-27 20:18       ` Glauber Costa
2009-07-27 21:08         ` [Qemu-devel] [PATCH] fix migration to not require -S Paolo Bonzini
2009-07-27 21:17         ` [Qemu-devel] [PATCH alternative] fix migration to obey -S Paolo Bonzini
2009-07-27 21:29           ` [Qemu-devel] " Glauber Costa
2009-07-27 21:36             ` Anthony Liguori
2009-07-27 23:15               ` Glauber Costa
2009-07-27 23:13                 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A6A61D4.1080807@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=glommer@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.