* [PATCH] block: fix improper kobject release in blk_integrity_unregister
@ 2009-07-24 8:52 Xiaotian Feng
2009-07-28 7:10 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Xiaotian Feng @ 2009-07-24 8:52 UTC (permalink / raw)
To: axboe, tj, linux-kernel; +Cc: Xiaotian Feng
blk_integrity_unregister should use kobject_put to release the kobject,
otherwise after bi is freed, memory of bi->kobj->name is leaked.
Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
---
block/blk-integrity.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/block/blk-integrity.c b/block/blk-integrity.c
index 73e28d3..15c6308 100644
--- a/block/blk-integrity.c
+++ b/block/blk-integrity.c
@@ -379,6 +379,7 @@ void blk_integrity_unregister(struct gendisk *disk)
kobject_uevent(&bi->kobj, KOBJ_REMOVE);
kobject_del(&bi->kobj);
+ kobject_put(&bi->kobj);
kmem_cache_free(integrity_cachep, bi);
disk->integrity = NULL;
}
--
1.6.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: fix improper kobject release in blk_integrity_unregister
2009-07-24 8:52 [PATCH] block: fix improper kobject release in blk_integrity_unregister Xiaotian Feng
@ 2009-07-28 7:10 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2009-07-28 7:10 UTC (permalink / raw)
To: Xiaotian Feng; +Cc: tj, linux-kernel
On Fri, Jul 24 2009, Xiaotian Feng wrote:
> blk_integrity_unregister should use kobject_put to release the kobject,
> otherwise after bi is freed, memory of bi->kobj->name is leaked.
Applied, thanks.
>
> Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
> ---
> block/blk-integrity.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/block/blk-integrity.c b/block/blk-integrity.c
> index 73e28d3..15c6308 100644
> --- a/block/blk-integrity.c
> +++ b/block/blk-integrity.c
> @@ -379,6 +379,7 @@ void blk_integrity_unregister(struct gendisk *disk)
>
> kobject_uevent(&bi->kobj, KOBJ_REMOVE);
> kobject_del(&bi->kobj);
> + kobject_put(&bi->kobj);
> kmem_cache_free(integrity_cachep, bi);
> disk->integrity = NULL;
> }
> --
> 1.6.2.5
>
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-28 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-24 8:52 [PATCH] block: fix improper kobject release in blk_integrity_unregister Xiaotian Feng
2009-07-28 7:10 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.