From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: 2273 lines in 170 files consists of only space and tabulators
Date: Tue, 28 Jul 2009 20:19:20 +0200 [thread overview]
Message-ID: <20090728181920.GM32726@thorin> (raw)
In-Reply-To: <1244667896.8525.17.camel@fz.local>
On Wed, Jun 10, 2009 at 11:04:56PM +0200, Felix Zielcke wrote:
> Am Samstag, den 06.06.2009, 21:53 -0400 schrieb Pavel Roskin:
> > On Sat, 2009-06-06 at 12:25 +0200, Felix Zielcke wrote:
> > > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|wc -l
> > > 2273
> > > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|sed -e 's/:.*//'|uniq|wc -l
> > > 170
> > >
> > > Anyone wants me to do
> > > find . -type f -print0 | xargs -0 sed -i -r -e 's/^[[:blank:]]+$//'
> > > or does someone object?
> > > [:blank:] doestn't contain these ^L chars.
> > >
> > > By the way `git diff --color' shows if you introduce such a line with
> > > red, but strangely not when you remove one.
> >
> > Since we have linear development, it shouldn't be a problem for merging
> > patches. Besides, "patch" can be told to ignore whitespace differences.
> >
> > However, I would prefer that we remove all trailing whitespace, not just
> > that on empty lines. That is, remove "^" from the sed expression.
>
> Ok I just commited this.
Do you mean removing all whitespace? I think you forgot to commit it.
Though, I'd prefer if we don't do this in one megacommit. If we do it
gradually, we avoid breaking patches. This makes work easier for branches
and for distributors (which essentially operate as a branch).
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2009-07-28 21:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-06 10:25 2273 lines in 170 files consists of only space and tabulators Felix Zielcke
2009-06-06 13:43 ` Felix Zielcke
2009-06-07 1:48 ` Vladimir 'phcoder' Serbinenko
2009-06-07 1:59 ` Pavel Roskin
2009-06-07 14:32 ` Felix Zielcke
2009-06-07 1:53 ` Pavel Roskin
2009-06-10 21:04 ` Felix Zielcke
2009-07-28 18:19 ` Robert Millan [this message]
2009-07-28 21:09 ` Felix Zielcke
2009-07-31 15:39 ` Robert Millan
2009-07-31 15:45 ` Felix Zielcke
2009-07-31 16:02 ` Felix Zielcke
2009-07-31 16:24 ` Robert Millan
2009-08-01 10:05 ` Alfred M. Szmidt
2009-08-01 13:54 ` Felix Zielcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090728181920.GM32726@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.