All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Nicolas Palix <npalix@diku.dk>,
	hjanssen@microsoft.com, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Staging: hv: Fix warning by casting a (const void
Date: Wed, 29 Jul 2009 13:13:24 +0000	[thread overview]
Message-ID: <20090729131324.GA28049@suse.de> (raw)
In-Reply-To: <200907291508.24608.arnd@arndb.de>

On Wed, Jul 29, 2009 at 03:08:24PM +0200, Arnd Bergmann wrote:
> On Wednesday 29 July 2009, Nicolas Palix wrote:
> > Fix compilation warning by casting the const void *Buffer
> > variable into a void *.
> > 
> > Signed-off-by: Nicolas Palix <npalix@diku.dk>
> 
> Not sure if this one is worthwhile. Replacing SG_BUFFER_LIST
> with the existing struct scatterlist might be a better
> fix, as sg_set_buf() does not generate a warning like this
> anyway.

Yes, that's the correct fix to make.  That should be done instead.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Nicolas Palix <npalix@diku.dk>,
	hjanssen@microsoft.com, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Staging: hv: Fix warning by casting a (const void *) to (void *)
Date: Wed, 29 Jul 2009 06:13:24 -0700	[thread overview]
Message-ID: <20090729131324.GA28049@suse.de> (raw)
In-Reply-To: <200907291508.24608.arnd@arndb.de>

On Wed, Jul 29, 2009 at 03:08:24PM +0200, Arnd Bergmann wrote:
> On Wednesday 29 July 2009, Nicolas Palix wrote:
> > Fix compilation warning by casting the const void *Buffer
> > variable into a void *.
> > 
> > Signed-off-by: Nicolas Palix <npalix@diku.dk>
> 
> Not sure if this one is worthwhile. Replacing SG_BUFFER_LIST
> with the existing struct scatterlist might be a better
> fix, as sg_set_buf() does not generate a warning like this
> anyway.

Yes, that's the correct fix to make.  That should be done instead.

thanks,

greg k-h

  reply	other threads:[~2009-07-29 13:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-29 12:10 [PATCH 4/4] Staging: hv: Fix warning by casting a (const void *) to (void *) Nicolas Palix
2009-07-29 12:10 ` Nicolas Palix
2009-07-29 13:02 ` [PATCH 4/4] Staging: hv: Fix warning by casting a (const void Greg KH
2009-07-29 13:02   ` [PATCH 4/4] Staging: hv: Fix warning by casting a (const void *) to (void *) Greg KH
2009-07-29 20:13   ` [PATCH 4/4] Staging: hv: Fix warning by casting a (const void Hank Janssen
2009-07-29 20:13     ` [PATCH 4/4] Staging: hv: Fix warning by casting a (const void *) to (void *) Hank Janssen
2009-07-29 20:44     ` [PATCH 4/4] Staging: hv: Fix warning by casting a (const void Greg KH
2009-07-29 20:44       ` [PATCH 4/4] Staging: hv: Fix warning by casting a (const void *) to (void *) Greg KH
2009-07-29 13:03 ` [PATCH 4/4] Staging: hv: Fix warning by casting a (const void Joe Perches
2009-07-29 13:03   ` [PATCH 4/4] Staging: hv: Fix warning by casting a (const void *) to (void *) Joe Perches
2009-07-29 13:08 ` Arnd Bergmann
2009-07-29 13:08   ` Arnd Bergmann
2009-07-29 13:13   ` Greg KH [this message]
2009-07-29 13:13     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090729131324.GA28049@suse.de \
    --to=gregkh@suse.de \
    --cc=arnd@arndb.de \
    --cc=hjanssen@microsoft.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npalix@diku.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.