Re: [Qemu-devel] [PATCH v2] make windows notice media change

[Gleb Natapov <gleb@redhat.com>]

On Wed, Jul 29, 2009 at 04:35:52PM +0200, Filip Navara wrote:
> On Wed, Jul 29, 2009 at 3:50 PM, Gleb Natapov<gleb@redhat.com> wrote:
> [snip]
> > @@ -2898,6 +2901,7 @@ static void ide_load(QEMUFile* f, IDEState *s)
> >
> >     qemu_get_8s(f, &s->sense_key);
> >     qemu_get_8s(f, &s->asc);
> > +    qemu_get_8s(f, &s->cdrom_changed);
> >     /* XXX: if a transfer is pending, we do not save it yet */
> >  }
> >
> > @@ -3219,7 +3223,7 @@ static int pci_ide_load(QEMUFile* f, void *opaque, int version_id)
> >     PCIIDEState *d = opaque;
> >     int ret, i;
> >
> > -    if (version_id != 2)
> > +    if (version_id != 3)
> >         return -EINVAL;
> >     ret = pci_device_load(&d->dev, f);
> >     if (ret < 0)
> 
> Why shouldn't we support loading version 2 snapshots? Afterall that's
> why we had the versioning in the first place.
> 
Does anybody check cross version migration? If no my guess is it is broken.
And I can't even imaging test matrix. Versioning is a good way to
prevent users from doing stupid things.

--
			Gleb.