All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Filip Navara <filip.navara@gmail.com>, Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] make windows notice media change
Date: Wed, 29 Jul 2009 20:52:35 +0100	[thread overview]
Message-ID: <200907292052.35755.paul@codesourcery.com> (raw)
In-Reply-To: <5b31733c0907291224h340921f0j72195618b0b6cd2a@mail.gmail.com>

> >>> Why shouldn't we support loading version 2 snapshots? Afterall that's
> >>> why we had the versioning in the first place.
> >>
> >> No it's not. Versioning was introduced to *prevent* loading old
> >> snapshots and crashing or ending up with inconsistent guest state. I'm
> >> still unconvinced that anything other than very short term backward
> >> compatibility is worthwhile or even viable.
> >
> > I see it as a way to migrate a running guest to newer QEMU version,
> > possibly even with live migration. In fact I used it quite often back in
> > the day when snapshots were not part of qcow2 yet and when kqemu was
> > still in its heydays.
>
> BTW, why would there be the version parameter in the first place if it
> wasn't supposed to load older versions?!

Like I already said: it's there to prevent an old version being loaded 
accidentally. Without this an incompatible change will  result in anything 
from a crash to corrupt/inconsistent guest state. Versioning allows us to 
reject the snapshot and fail safely.

Paul

  parent reply	other threads:[~2009-07-29 19:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-29 12:07 [Qemu-devel] [PATCH] make windows notice media change Gleb Natapov
2009-07-29 13:50 ` [Qemu-devel] [PATCH v2] " Gleb Natapov
2009-07-29 14:22   ` Avi Kivity
2009-07-29 14:21     ` Gleb Natapov
2009-07-29 14:44       ` Avi Kivity
2009-07-29 14:35   ` Filip Navara
2009-07-29 14:40     ` Gleb Natapov
2009-07-29 14:59       ` Stefano Stabellini
2009-07-29 19:11     ` Paul Brook
2009-07-29 19:18       ` Filip Navara
2009-07-29 19:24         ` Filip Navara
2009-07-29 19:34           ` Anthony Liguori
2009-07-29 19:52           ` Paul Brook [this message]
2009-07-29 19:56             ` Filip Navara
2009-07-29 20:05               ` Paul Brook
2009-07-29 20:14                 ` Gleb Natapov
2009-07-30 12:14                 ` Stefano Stabellini
2009-07-30 12:27                   ` Paul Brook
2009-07-29 19:33     ` Anthony Liguori
2009-07-29 19:44       ` [Qemu-devel] " Juan Quintela
2009-07-29 20:05         ` Anthony Liguori
2009-07-29 20:09           ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907292052.35755.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=filip.navara@gmail.com \
    --cc=gleb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.