Re: Commit 2e0fa4918d643ce6ec0299cd31cfe1c346e4bce3 breaks libtool's do_configure [PATCH]

[Marc Olzheim <zlo@zlo.nu>]

[-- Attachment #1: Type: text/plain, Size: 1773 bytes --]

On Thu, Jul 30, 2009 at 01:14:24PM +0200, Stanislav Brabec wrote:
> > I'm not sure how you tested this, but there are quotes missing, so that
> > the "-E" argument to "grep" is passed to "export" instead. I guess some
> > shells have a "-E" flag to "export", so it is silently ignored, but mine
> > don't.
> 
> I tried both versions - quoted and unquoted - before the commit. Both
> worked for me, that is why I committed the shorter one.
> 
> Well, adding quotes is safe. Can you check your configure output and
> host shell version?
> 
> My configure output:
> 
> checking for a sed that does not truncate output... (cached) /bin/sed
> checking for grep that handles long lines and -e... (cached) /bin/sed
> checking for egrep... (cached) /bin/grep -E
> checking for fgrep... (cached) /bin/grep -F
> 
> It indicates, that it worked correctly.
> 
> My native shell is:
> 
> /OE/openembedded/build> sh --version
> GNU bash, version 4.0.24(1)-release (x86_64-suse-linux-gnu)

Hmm, what I got was:

(task 365) ERROR: function do_configure failed
(task 365) ERROR: log data follows
(/home/marcolz/src/iphion-new-oe3/embbuild/tmp/work/i686-oe-linux/libtool-cross-2.2.6a-r0/temp/log.do_configure.22690)
| export: 929: -E: bad variable name
(task 365) NOTE: Task failed:
/home/marcolz/src/iphion-new-oe3/embbuild/tmp/work/i686-oe-linux/libtool-cross-2.2.6a-r0/temp/log.do_configure.22690
(task 365) ERROR: TaskFailed event exception, aborting
(task 365) ERROR: Build of
/home/marcolz/src/iphion-new-oe3/embbuild/openembedded.iphion/recipes/libtool/libtool-cross_2.2.6a.bb
do_configure failed


My local bash version is:

GNU bash, version 3.2.39(1)-release (i486-pc-linux-gnu)
Copyright (C) 2007 Free Software Foundation, Inc.

Marc

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 204 bytes --]