Re: Commit 2e0fa4918d643ce6ec0299cd31cfe1c346e4bce3 breaks libtool's do_configure [PATCH]

[Marc Olzheim <zlo@zlo.nu>]

[-- Attachment #1.1: Type: text/plain, Size: 625 bytes --]

On Thu, Jul 30, 2009 at 03:22:19PM +0200, Leon Woestenberg wrote:
> > My /bin/sh is a dash, I should have known, my apologies.  I have a patch
> >
> Testing with dash rather than bash is GOOD due to it adhering to POSIX
> without much of the bash-specifics.

Well, I agree, but judging by commit
e0ed375a8dfb292bdd72f5891917ef81f361f15c to classes/sanity.bbclass, I
assumed the policy was to require /bin/bash for /bin/sh instead of
fixing bashisms.

To not be obligated to use bash, I added the attached patch.

> So please do not introduce 'bashisms'  (dependencies on bash behaviour).

I agree ;-)

Marc

[-- Attachment #1.2: dash.patch --]
[-- Type: text/x-diff, Size: 1039 bytes --]

commit d37e8ae3fb24b589793ae92062d665cc6384151e
Author: Marc Olzheim <marc@iphion.nl>
Date:   Thu Jun 11 12:44:34 2009 +0200

    Make allowing dash as /bin/sh a configuration option.

diff --git a/classes/sanity.bbclass b/classes/sanity.bbclass
index 29624c3..3ee9a0a 100644
--- a/classes/sanity.bbclass
+++ b/classes/sanity.bbclass
@@ -112,11 +112,12 @@ def check_sanity(e):
 		missing = missing.rstrip(',')
 		messages = messages + "Please install following missing utilities: %s\n" % missing
 
-	try:
-	    if os.path.basename(os.readlink('/bin/sh')) == 'dash':
-		    messages = messages + "Using dash as /bin/sh causes various subtle build problems, please use bash instead.\n"
-	except:
-		pass
+	if not data.getVar( 'ALLOW_DASH_SH', e.data, True ):
+		try:
+		    if os.path.basename(os.readlink('/bin/sh')) == 'dash':
+			    messages = messages + "Using dash as /bin/sh causes various subtle build problems, please use bash instead.\n"
+		except:
+			pass
 
 	omask = os.umask(022)
 	if omask & 0755:

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 204 bytes --]