Re: [PATCH] KVM: VMX: Fix locking order in handle_invalid_guest_state

[Gleb Natapov <gleb@redhat.com>]

On Thu, Jul 30, 2009 at 02:47:30PM +0300, Gleb Natapov wrote:
> On Thu, Jul 30, 2009 at 02:46:59PM +0300, Avi Kivity wrote:
> > On 07/30/2009 02:24 PM, Gleb Natapov wrote:
> >>> Good (it was one of the goals of the original interrupt rework, ~2 years
> >>> ago)
> >>>
> >>>      
> >> But if we emulate an injection by playing with guest memory and
> >> registers we have to be sure we do it only once.
> >>    
> >
> > Once we've successfully updated the stack, inject is complete and we can  
> > remove the interrupt from the queue.
> >
> Then, it we skip actual guest entry for some reason, we will not be
> able to tell if we can inject next irq or not.
> 
Actually thinking about it when first irq is injected we should clear IF
flag, so the second one will not happen.

--
			Gleb.