From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: VMX: Fix locking order in handle_invalid_guest_state
Date: Sun, 26 Jul 2009 16:38:44 +0200 [thread overview]
Message-ID: <4A6C6A74.4030801@web.de> (raw)
In-Reply-To: <4A6C69F5.3020604@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
Avi Kivity wrote:
> On 07/26/2009 05:23 PM, Jan Kiszka wrote:
>>> btw, what does it fix? a debug warning?
>>>
>>>
>>
>> I haven't seen anything in the wild, and I don't think it would raise a
>> warning. All it should cause is a potential delay of some pending
>> reschedule as preempt_enable will not fire under local_irq_disable.
>>
>
> Ah, okay, then it is a real fix. Preempt-correctness is important.
>
> (but won't local_irq_enable() reschedule?)
The last time I checked it was essentially a plain 'sti'.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2009-07-26 14:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 21:53 [PATCH] KVM: VMX: Fix locking order in handle_invalid_guest_state Jan Kiszka
2009-07-23 21:45 ` Marcelo Tosatti
2009-07-24 7:00 ` Jan Kiszka
2009-07-26 13:51 ` Avi Kivity
2009-07-26 14:23 ` Jan Kiszka
2009-07-26 14:36 ` Avi Kivity
2009-07-26 14:38 ` Jan Kiszka [this message]
2009-07-26 14:47 ` Avi Kivity
2009-07-26 14:55 ` Jan Kiszka
2009-07-26 15:02 ` Avi Kivity
2009-07-29 12:24 ` Marcelo Tosatti
2009-07-29 12:44 ` Avi Kivity
2009-07-29 14:07 ` Marcelo Tosatti
2009-07-29 14:32 ` Gleb Natapov
2009-07-30 11:16 ` Avi Kivity
2009-07-30 11:16 ` Gleb Natapov
2009-07-30 11:26 ` Avi Kivity
2009-07-30 11:24 ` Gleb Natapov
2009-07-30 11:46 ` Avi Kivity
2009-07-30 11:47 ` Gleb Natapov
2009-07-30 11:57 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6C6A74.4030801@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.