From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: rusty@rustcorp.com.au
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
lguest@ozlabs.org, sfr@canb.auug.org.au
Subject: [PATCH] next-20090730 lguest build breaks with pfn_pmd()
Date: Thu, 30 Jul 2009 17:35:33 +0530 [thread overview]
Message-ID: <20090730120533.GB4955@linux.vnet.ibm.com> (raw)
In-Reply-To: <20090729173611.b82478cd.sfr@canb.auug.org.au>
Hi Rusty,
next-20090729 allmodconfig build breaks at
drivers/lguest/page_tables.c: In function 'setup_pagetables':
drivers/lguest/page_tables.c:987: error: incompatible type for argument 2 of 'pfn_pmd'
drivers/lguest/page_tables.c:994: error: expected ';' before ')' token
drivers/lguest/page_tables.c:994: error: expected statement before ')' token
make[2]: *** [drivers/lguest/page_tables.o] Error 1
build failure is introduced by commit e07dd6220a4bf81a2549e7e37523a2557547d9d7
I have tested the patch for the build failure only.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
drivers/lguest/page_tables.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/lguest/page_tables.c b/drivers/lguest/page_tables.c
index 8c86446..c610b82 100644
--- a/drivers/lguest/page_tables.c
+++ b/drivers/lguest/page_tables.c
@@ -984,14 +984,14 @@ static unsigned long setup_pagetables(struct lguest *lg,
for (i = j = 0; i < mapped_pages && j < PTRS_PER_PMD;
i += PTRS_PER_PTE, j++) {
pmd = pfn_pmd(((unsigned long)&linear[i] - mem_base)/PAGE_SIZE,
- _PAGE_PRESENT | _PAGE_RW | _PAGE_USER);
+ __pgrot(_PAGE_PRESENT | _PAGE_RW | _PAGE_USER));
if (copy_to_user(&pmds[j], &pmd, sizeof(pmd)) != 0)
return -EFAULT;
}
/* One PGD entry, pointing to that PMD page. */
- pgd = __pgd(((unsigned long)pmds - mem_base) | _PAGE_PRESENT));
+ pgd = __pgd(((unsigned long)pmds - mem_base) | _PAGE_PRESENT);
/* Copy it in as the first PGD entry (ie. addresses 0-1G). */
if (copy_to_user(&pgdir[0], &pgd, sizeof(pgd)) != 0)
return -EFAULT;
Kamalesh
next prev parent reply other threads:[~2009-07-30 12:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 7:36 linux-next: Tree for July 29 Stephen Rothwell
2009-07-29 15:04 ` Next July 29 : Hugetlb test failure (OOPS free_hugepte_range) Sachin Sant
2009-07-29 15:04 ` Sachin Sant
2009-07-30 12:25 ` Sachin Sant
2009-07-30 12:30 ` Benjamin Herrenschmidt
2009-08-05 10:43 ` Sachin Sant
2009-08-06 3:52 ` Benjamin Herrenschmidt
2009-08-06 4:40 ` Sachin Sant
2009-08-05 14:35 ` Kumar Gala
2009-08-05 14:35 ` Kumar Gala
2009-08-05 15:33 ` Sachin Sant
2009-08-05 15:33 ` Sachin Sant
2009-07-30 12:05 ` Kamalesh Babulal [this message]
[not found] ` <20090730120533.GB4955-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2009-07-30 23:19 ` [PATCH] next-20090730 lguest build breaks with pfn_pmd() Rusty Russell
2009-07-30 23:19 ` Rusty Russell
2009-07-31 18:03 ` Randy Dunlap
2009-08-03 8:28 ` [RESEND-PATCH] " Kamalesh Babulal
2009-08-03 23:21 ` [PATCH] " Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090730120533.GB4955@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.