From: Rusty Russell <rusty@rustcorp.com.au>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
lguest@ozlabs.org, sfr@canb.auug.org.au
Subject: Re: [PATCH] next-20090730 lguest build breaks with pfn_pmd()
Date: Tue, 4 Aug 2009 08:51:31 +0930 [thread overview]
Message-ID: <200908040851.31556.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090731110356.cd0bc550.randy.dunlap@oracle.com>
On Sat, 1 Aug 2009 03:33:56 am Randy Dunlap wrote:
> On Thu, 30 Jul 2009 17:35:33 +0530 Kamalesh Babulal wrote:
> > @@ -984,14 +984,14 @@ static unsigned long setup_pagetables(struct lguest *lg,
> > for (i = j = 0; i < mapped_pages && j < PTRS_PER_PMD;
> > i += PTRS_PER_PTE, j++) {
> > pmd = pfn_pmd(((unsigned long)&linear[i] - mem_base)/PAGE_SIZE,
> > - _PAGE_PRESENT | _PAGE_RW | _PAGE_USER);
> > + __pgrot(_PAGE_PRESENT | _PAGE_RW | _PAGE_USER));
>
> s/__pgrot/__pgprot/
Damn, sorry. I threw this patch in linux-next and went skiing.
Kamalesh said:
"I have tested the patch for the build failure only."
This was clearly untrue. Don't do that again, or I'll just ignore your
emails.
Rusty.
prev parent reply other threads:[~2009-08-03 23:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 7:36 linux-next: Tree for July 29 Stephen Rothwell
2009-07-29 15:04 ` Next July 29 : Hugetlb test failure (OOPS free_hugepte_range) Sachin Sant
2009-07-29 15:04 ` Sachin Sant
2009-07-30 12:25 ` Sachin Sant
2009-07-30 12:30 ` Benjamin Herrenschmidt
2009-08-05 10:43 ` Sachin Sant
2009-08-06 3:52 ` Benjamin Herrenschmidt
2009-08-06 4:40 ` Sachin Sant
2009-08-05 14:35 ` Kumar Gala
2009-08-05 14:35 ` Kumar Gala
2009-08-05 15:33 ` Sachin Sant
2009-08-05 15:33 ` Sachin Sant
2009-07-30 12:05 ` [PATCH] next-20090730 lguest build breaks with pfn_pmd() Kamalesh Babulal
[not found] ` <20090730120533.GB4955-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2009-07-30 23:19 ` Rusty Russell
2009-07-30 23:19 ` Rusty Russell
2009-07-31 18:03 ` Randy Dunlap
2009-08-03 8:28 ` [RESEND-PATCH] " Kamalesh Babulal
2009-08-03 23:21 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908040851.31556.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.