From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: krkumar2@in.ibm.com, jarkao2@gmail.com, kaber@trash.net,
netdev@vger.kernel.org
Subject: Re: [RFC] [PATCH] Avoid enqueuing skb for default qdiscs
Date: Mon, 03 Aug 2009 20:55:25 -0700 (PDT) [thread overview]
Message-ID: <20090803.205525.156945388.davem@davemloft.net> (raw)
In-Reply-To: <20090804034910.GA30871@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 4 Aug 2009 11:49:10 +0800
> On Mon, Aug 03, 2009 at 08:29:35PM -0700, David Miller wrote:
>>
>> Although PFIFO is not work-conserving, isn't it important to retain
>> ordering? What if higher priority packets are in the queue when we
>> enqueue? This new bypass will send the wrong packet, won't it?
>
> The bypass only kicks in if the queue length is zero.
Thanks for explaining, makes sense now.
>> I'm beginning to think, if we want to make the default case go as fast
>> as possible, we should just bypass everything altogether. The entire
>> qdisc layer, all of it.
>
> Can you be more specific? AFAICS he's already bypassing the qdisc
> layer when it can be done safely.
Ignore this, it's based upon my missing the part where this
bypass only triggers when the qdisc is empty.
next prev parent reply other threads:[~2009-08-04 3:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090728155055.2266.41649.sendpatchset@localhost.localdomain>
2009-08-02 8:51 ` [RFC] [PATCH] Avoid enqueuing skb for default qdiscs Krishna Kumar2
2009-08-03 7:15 ` Jarek Poplawski
2009-08-03 8:09 ` Krishna Kumar2
2009-08-04 3:29 ` David Miller
2009-08-04 3:49 ` Herbert Xu
2009-08-04 3:55 ` David Miller [this message]
2009-08-04 6:45 ` Krishna Kumar2
[not found] <20090803081016.32746.23400.sendpatchset@localhost.localdomain>
2009-08-03 9:17 ` Krishna Kumar2
2009-08-03 9:58 ` Jarek Poplawski
2009-08-03 19:38 ` Jarek Poplawski
2009-08-03 20:22 ` Jarek Poplawski
2009-08-04 6:55 ` Krishna Kumar2
2009-08-04 7:22 ` Jarek Poplawski
2009-08-04 15:51 Krishna Kumar
2009-08-04 16:21 ` Krishna Kumar2
2009-08-04 20:23 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803.205525.156945388.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.