Re: [RFC] [PATCH] Avoid enqueuing skb for default qdiscs

[Jarek Poplawski <jarkao2@gmail.com>]

On Mon, Aug 03, 2009 at 09:38:47PM +0200, Jarek Poplawski wrote:
> Krishna Kumar2 wrote, On 08/03/2009 11:17 AM:
> > Krishna Kumar2/India/IBM@IBMIN wrote on 08/03/2009 01:40:16 PM:
> > 
> >> Krishna Kumar2/India/IBM@IBMIN
> >> 08/03/2009 01:40 PM
...
> >> [RFC] [PATCH] Avoid enqueuing skb for default qdiscs
> >>
> >> From: Krishna Kumar <krkumar2@in.ibm.com>
...
> >> @@ -547,8 +561,11 @@ void qdisc_reset(struct Qdisc *qdisc)
> >>     if (ops->reset)
> >>        ops->reset(qdisc);
> >>
> >> -   kfree_skb(qdisc->gso_skb);
> >> -   qdisc->gso_skb = NULL;
> >> +   if (qdisc->gso_skb) {
> >> +      kfree_skb(qdisc->gso_skb);
> >> +      qdisc->gso_skb = NULL;
> >> +      qdisc->q.qlen--;
> 
> You don't need this here: qdiscs should zero it in ops->reset().

Actually, there're some exceptions, so until it's fixed maybe you
should better zero it here too.

Jarek P.

> 
> >> +   }
> >>  }
> >>  EXPORT_SYMBOL(qdisc_reset);