From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [Patch 2/3] cldcli: suppress warnings from -Wshadow
Date: Mon, 3 Aug 2009 22:11:03 -0600 [thread overview]
Message-ID: <20090803221103.6e5bd50c@redhat.com> (raw)
In-Reply-To: <4A7798BA.6010906@garzik.org>
On Mon, 03 Aug 2009 22:11:06 -0400, Jeff Garzik <jeff@garzik.org> wrote:
> I think the root cause is poorly named globals, so instead of applying
> this patch, I added a "thr_" prefix to the globals 'fh' and 'udp'.
>
> I also fixed the other -Wshadow warnings as well, even though they were
> largely harmless (variable name matched a system function name).
By all means, thanks.
-- Pete
prev parent reply other threads:[~2009-08-04 4:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 1:54 [Patch 2/3] cldcli: suppress warnings from -Wshadow Pete Zaitcev
2009-08-04 2:11 ` Jeff Garzik
2009-08-04 4:11 ` Pete Zaitcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803221103.6e5bd50c@redhat.com \
--to=zaitcev@redhat.com \
--cc=hail-devel@vger.kernel.org \
--cc=jeff@garzik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.