All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/6] pulse: replace manual mainloop by pa_mainloop_iterate()
@ 2009-08-04 21:53 Lennart Poettering
  2009-08-04 22:02 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Lennart Poettering @ 2009-08-04 21:53 UTC (permalink / raw)
  To: ALSA Development Mailing List

The pa_mainloop_prepare()/_poll()/_dispatch() can be simplified by
simply calling pa_mainloop_iterate() which does all this in one call.
---
 pulse/conf_pulse.c |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)

diff --git a/pulse/conf_pulse.c b/pulse/conf_pulse.c
index 3f9e071..35dd383 100644
--- a/pulse/conf_pulse.c
+++ b/pulse/conf_pulse.c
@@ -61,15 +61,7 @@ conf_pulse_hook_load_if_running(snd_config_t * root, snd_config_t * config,
 		goto out;
 
 	do {
-		err = pa_mainloop_prepare(loop, -1);
-		if (err < 0)
-			goto out;
-
-		err = pa_mainloop_poll(loop);
-		if (err < 0)
-			goto out;
-
-		err = pa_mainloop_dispatch(loop);
+		err = pa_mainloop_iterate(loop, 1, NULL);
 		if (err < 0)
 			goto out;
 
-- 
1.6.4



Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net         ICQ# 11060553
http://0pointer.net/lennart/           GnuPG 0x1A015CC4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/6] pulse: replace manual mainloop by pa_mainloop_iterate()
  2009-08-04 21:53 [PATCH 1/6] pulse: replace manual mainloop by pa_mainloop_iterate() Lennart Poettering
@ 2009-08-04 22:02 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-08-04 22:02 UTC (permalink / raw)
  To: Lennart Poettering; +Cc: ALSA Development Mailing List

At Tue, 4 Aug 2009 23:53:51 +0200,
Lennart Poettering wrote:
> 
> The pa_mainloop_prepare()/_poll()/_dispatch() can be simplified by
> simply calling pa_mainloop_iterate() which does all this in one call.

Applied all 6 patches now (with a build fix).  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-08-04 22:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-04 21:53 [PATCH 1/6] pulse: replace manual mainloop by pa_mainloop_iterate() Lennart Poettering
2009-08-04 22:02 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.