Re: [tip:x86/apic] x86/apic: Enable x2APIC without interrupt remapping under KVM

[Gleb Natapov <gleb@redhat.com>]

On Wed, Aug 05, 2009 at 03:19:23PM +0300, Gleb Natapov wrote:
> On Wed, Aug 05, 2009 at 02:16:21PM +0200, Ingo Molnar wrote:
> > 
> > * Gleb Natapov <gleb@redhat.com> wrote:
> > 
> > > +static inline void x2apic_force_phys()
> > > +{
> > > +}
> > 
> > Sigh. Have you tested this patche and have you looked at the 
> > resultig compiler output?
> > 
> I haven't looked and compiler output. What is wrong with it?
> Is defining this function as #define would be batter?
> 
Actually I made it a define initially and tested with it. Later I change
it to be inline and apparently tested only with x2apic enabled. I see the
problem now. Do you want it to be define or properly defined empty inline
function like any other function in this code?

--
			Gleb.