* [PATCH] perf report: Make --sort comm,dso,symbol the default
@ 2009-08-05 10:25 Pekka Enberg
2009-08-05 10:41 ` Peter Zijlstra
2009-08-05 11:18 ` [tip:perfcounters/urgent] " tip-bot for Pekka Enberg
0 siblings, 2 replies; 4+ messages in thread
From: Pekka Enberg @ 2009-08-05 10:25 UTC (permalink / raw)
To: mingo; +Cc: linux-kernel, acme, a.p.zijlstra
If you're doing performance testing, you're interested in the symbols
anyway so lets make "--sort comm,dso,symbol" the default sort option.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
---
tools/perf/builtin-report.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index b20a4b6..181cef1 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -31,7 +31,7 @@
static char const *input_name = "perf.data";
static char *vmlinux = NULL;
-static char default_sort_order[] = "comm,dso";
+static char default_sort_order[] = "comm,dso,symbol";
static char *sort_order = default_sort_order;
static char *dso_list_str, *comm_list_str, *sym_list_str,
*col_width_list_str;
@@ -1423,7 +1423,7 @@ print_entries:
if (sort_order == default_sort_order &&
parent_pattern == default_parent_pattern) {
fprintf(fp, "#\n");
- fprintf(fp, "# (For more details, try: perf report --sort comm,dso,symbol)\n");
+ fprintf(fp, "# (For an high level overview, try: perf report --sort comm,dso)\n");
fprintf(fp, "#\n");
}
fprintf(fp, "\n");
--
1.5.6.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] perf report: Make --sort comm,dso,symbol the default
2009-08-05 10:25 [PATCH] perf report: Make --sort comm,dso,symbol the default Pekka Enberg
@ 2009-08-05 10:41 ` Peter Zijlstra
2009-08-05 12:41 ` Arnaldo Carvalho de Melo
2009-08-05 11:18 ` [tip:perfcounters/urgent] " tip-bot for Pekka Enberg
1 sibling, 1 reply; 4+ messages in thread
From: Peter Zijlstra @ 2009-08-05 10:41 UTC (permalink / raw)
To: Pekka Enberg; +Cc: mingo, linux-kernel, acme
On Wed, 2009-08-05 at 13:25 +0300, Pekka Enberg wrote:
> If you're doing performance testing, you're interested in the symbols
> anyway so lets make "--sort comm,dso,symbol" the default sort option.
Seems sensible,
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
> ---
> tools/perf/builtin-report.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index b20a4b6..181cef1 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -31,7 +31,7 @@
> static char const *input_name = "perf.data";
> static char *vmlinux = NULL;
>
> -static char default_sort_order[] = "comm,dso";
> +static char default_sort_order[] = "comm,dso,symbol";
> static char *sort_order = default_sort_order;
> static char *dso_list_str, *comm_list_str, *sym_list_str,
> *col_width_list_str;
> @@ -1423,7 +1423,7 @@ print_entries:
> if (sort_order == default_sort_order &&
> parent_pattern == default_parent_pattern) {
> fprintf(fp, "#\n");
> - fprintf(fp, "# (For more details, try: perf report --sort comm,dso,symbol)\n");
> + fprintf(fp, "# (For an high level overview, try: perf report --sort comm,dso)\n");
> fprintf(fp, "#\n");
> }
> fprintf(fp, "\n");
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] perf report: Make --sort comm,dso,symbol the default
2009-08-05 10:41 ` Peter Zijlstra
@ 2009-08-05 12:41 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2009-08-05 12:41 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Arnaldo Carvalho de Melo, Pekka Enberg, Ingo Molnar, linux-kernel
Em Wed, Aug 05, 2009 at 12:41:18PM +0200, Peter Zijlstra escreveu:
> On Wed, 2009-08-05 at 13:25 +0300, Pekka Enberg wrote:
> > If you're doing performance testing, you're interested in the symbols
> > anyway so lets make "--sort comm,dso,symbol" the default sort option.
>
> Seems sensible,
>
> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:perfcounters/urgent] perf report: Make --sort comm,dso,symbol the default
2009-08-05 10:25 [PATCH] perf report: Make --sort comm,dso,symbol the default Pekka Enberg
2009-08-05 10:41 ` Peter Zijlstra
@ 2009-08-05 11:18 ` tip-bot for Pekka Enberg
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Pekka Enberg @ 2009-08-05 11:18 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, penberg, peterz, tglx, mingo
Commit-ID: 114cfab222233f50f46d7162cf7d99fdc6c271e5
Gitweb: http://git.kernel.org/tip/114cfab222233f50f46d7162cf7d99fdc6c271e5
Author: Pekka Enberg <penberg@cs.helsinki.fi>
AuthorDate: Wed, 5 Aug 2009 13:25:21 +0300
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 5 Aug 2009 13:16:04 +0200
perf report: Make --sort comm,dso,symbol the default
If you're doing performance testing, you're interested in the
symbols anyway so lets make "--sort comm,dso,symbol" the
default sort option.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: acme@redhat.com
LKML-Reference: <1249467921-10450-1-git-send-email-penberg@cs.helsinki.fi>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
tools/perf/builtin-report.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index ce4f286..8cb58d6 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -31,7 +31,7 @@
static char const *input_name = "perf.data";
static char *vmlinux = NULL;
-static char default_sort_order[] = "comm,dso";
+static char default_sort_order[] = "comm,dso,symbol";
static char *sort_order = default_sort_order;
static char *dso_list_str, *comm_list_str, *sym_list_str,
*col_width_list_str;
@@ -1424,7 +1424,7 @@ print_entries:
if (sort_order == default_sort_order &&
parent_pattern == default_parent_pattern) {
fprintf(fp, "#\n");
- fprintf(fp, "# (For more details, try: perf report --sort comm,dso,symbol)\n");
+ fprintf(fp, "# (For a higher level overview, try: perf report --sort comm,dso)\n");
fprintf(fp, "#\n");
}
fprintf(fp, "\n");
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-08-05 12:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-05 10:25 [PATCH] perf report: Make --sort comm,dso,symbol the default Pekka Enberg
2009-08-05 10:41 ` Peter Zijlstra
2009-08-05 12:41 ` Arnaldo Carvalho de Melo
2009-08-05 11:18 ` [tip:perfcounters/urgent] " tip-bot for Pekka Enberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.