From: Stephen Hemminger <shemminger@vyatta.com>
To: Mike McCormack <mikem@ring3k.org>
Cc: netdev@vger.kernel.org, Rene Mayrhofer <rene@mayrhofer.eu.org>,
Richard Leitner <leitner@esys.at>
Subject: Re: [PATCH] sky2: Serialize access to PCI config space
Date: Thu, 6 Aug 2009 08:34:36 -0700 [thread overview]
Message-ID: <20090806083436.2879bf7b@nehalam> (raw)
In-Reply-To: <4A7ABA23.6060201@ring3k.org>
On Thu, 06 Aug 2009 20:10:27 +0900
Mike McCormack <mikem@ring3k.org> wrote:
> PCI config space may be shared across two device instances,
> or accessed from an interrupt
> , so serialize access so
> read-update-write operations do not interfere with each other.
>
> Only tested on a single port card, as my sky2 doesn't have dual ports.
>
> Signed-off-by: Mike McCormack <mikem@ring3k.org>
No, more locks is not better design. Better to just use existing
RTNL mutex consistently.
next prev parent reply other threads:[~2009-08-06 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 11:10 [PATCH] sky2: Serialize access to PCI config space Mike McCormack
2009-08-06 15:34 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-08-09 11:37 Mike McCormack
2009-08-10 15:23 ` Stephen Hemminger
2009-08-10 15:27 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090806083436.2879bf7b@nehalam \
--to=shemminger@vyatta.com \
--cc=leitner@esys.at \
--cc=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
--cc=rene@mayrhofer.eu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.