From: Christoph Hellwig <hch@infradead.org>
To: akpm@linux-foundation.org
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
msb@google.com, rlove@google.com
Subject: Re: [patch 09/12] sendfile: several fixes
Date: Thu, 6 Aug 2009 19:24:18 -0400 [thread overview]
Message-ID: <20090806232418.GA6279@infradead.org> (raw)
In-Reply-To: <200908062310.n76NAFKE012978@imap1.linux-foundation.org>
On Thu, Aug 06, 2009 at 04:10:15PM -0700, akpm@linux-foundation.org wrote:
> From: Mandeep Singh Baines <msb@google.com>
>
> Three fixes for sendfile, mostly related to sending large files from pseudo
> filesystems:
>
> - Fix sendfile for offsets > 300G. This can happen with pseudo filesystems.
> This happens because the overflow check is using inode->i_sb->s_maxbytes
> and not the superblock of the backing device's s_maxbytes. For a regular file
> these are interchangible but for a special file these are different and you
> want the latter.
>
> - Don't compare against the max of the out_inode's superblock. Doesn't make
> sense.
>
> - For pseudo and other filesystems with s_maxbytes set to ~0ULL, max ends up
> holding a negative number as it is signed. Check for and correct that.
The right fix is to not set s_maxbytes to ~0ULL. Jeff Layton has sent
some patches for that recently.
next prev parent reply other threads:[~2009-08-06 23:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 23:10 [patch 09/12] sendfile: several fixes akpm
2009-08-06 23:24 ` Christoph Hellwig [this message]
2009-08-06 23:25 ` Robert Love
2009-08-06 23:29 ` Christoph Hellwig
2009-08-07 6:12 ` Mandeep Singh Baines
2009-08-07 6:26 ` Andrew Morton
2009-08-07 11:29 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090806232418.GA6279@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=msb@google.com \
--cc=rlove@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.