From: Andrew Morton <akpm@linux-foundation.org>
To: Mandeep Singh Baines <msb@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
jlayton@redhat.com, Robert Love <rlove@google.com>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [patch 09/12] sendfile: several fixes
Date: Thu, 6 Aug 2009 23:26:55 -0700 [thread overview]
Message-ID: <20090806232655.b40f8191.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090807061216.GX24668@google.com>
On Thu, 6 Aug 2009 23:12:17 -0700 Mandeep Singh Baines <msb@google.com> wrote:
> Christoph Hellwig (hch@infradead.org) wrote:
> > On Thu, Aug 06, 2009 at 07:25:56PM -0400, Robert Love wrote:
> > > On Thu, Aug 6, 2009 at 7:24 PM, Christoph Hellwig<hch@infradead.org> wrote:
> > >
> > > > The right fix is to not set s_maxbytes to ~0ULL. ?Jeff Layton has sent
> > > > some patches for that recently.
> > >
>
> Yeah, found it here:
>
> http://lkml.org/lkml/2009/7/22/178
>
> > > I agree.
> > >
> > > I still think this check is worthwhile, given the signed/unsigned mismatch.
> >
> > I think the plan is to change s_maxbytes to be an loff_t which would
> > eliminate this. I'm not sure if Jeff has sent that patch already.
> >
>
> Yeah, found the discussion here:
>
> http://lkml.org/lkml/2009/7/22/241
>
> Cool. Didn't really like this check. It would be nice to remove the check
> and comment from the next version of this patch.
Jeff, can you please redo/refresh/review/resend that stuff?
Thanks.
next prev parent reply other threads:[~2009-08-07 6:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 23:10 [patch 09/12] sendfile: several fixes akpm
2009-08-06 23:24 ` Christoph Hellwig
2009-08-06 23:25 ` Robert Love
2009-08-06 23:29 ` Christoph Hellwig
2009-08-07 6:12 ` Mandeep Singh Baines
2009-08-07 6:26 ` Andrew Morton [this message]
2009-08-07 11:29 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090806232655.b40f8191.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=msb@google.com \
--cc=rlove@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.