From: Paul Mundt <lethal@linux-sh.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Kyungmin Park <kmpark@infradead.org>,
linux-sh@vger.kernel.org, tony@atomide.com,
linux-mtd@lists.infradead.org, akpm@linux-foundation.org,
linux-omap@vger.kernel.org, dwmw2@infradead.org
Subject: Re: [PATCH] mtd: make onenand/generic.c more generic
Date: Fri, 7 Aug 2009 14:30:20 +0900 [thread overview]
Message-ID: <20090807053020.GA902@linux-sh.org> (raw)
In-Reply-To: <aec7e5c30908062228g737c1f6cr25f6c67c07d80bd9@mail.gmail.com>
On Fri, Aug 07, 2009 at 02:28:01PM +0900, Magnus Damm wrote:
> On Wed, Aug 5, 2009 at 1:41 PM, Magnus Damm<magnus.damm@gmail.com> wrote:
> >> On Tue, Aug 4, 2009 at 6:20 PM, Magnus Damm<magnus.damm@gmail.com> wrote:
> >>> From: Magnus Damm <damm@igel.co.jp>
> >>>
> >>> This patch removes the ARM dependency from the generic "onenand"
> >>> platform device driver. This change makes the driver useful for
> >>> other architectures as well. Needed for the SuperH kfr2r09 board.
> >
> > On Wed, Aug 5, 2009 at 1:24 PM, Kyungmin Park<kmpark@infradead.org> wrote:
> >> Good idea add the onenand_platform_data, but dont' agree the renaming
> >> the onenand-flash.
> >> Other boards are use it even though it's not released it
> >
> > I suspected so. But this is the only reason why changed the name. =)
> >
> > If we don't change the name then the platform device will be attached
> > to the platform driver as usual, but the old platform data structure
> > will use a different binary format compated to what the driver
> > expects.
> >
> > Changing the driver name makes sure that the old device disappears and
> > that people can move over to the new name and at the same time update
> > the platform data to the new format.
> >
> >> Others are good.
> >
> > Thanks.
> >
> > I can post an updated version where I keep the driver name unchanged
> > if you prefer that. But I'm pretty sure out-of-tree drivers will break
> > with NULL pointer accesses or similar if we update the platform data
> > format without changing the name. I don't think you want that. =)
>
> Any update on this?
>
You have failed at reading your email:
http://lists.infradead.org/pipermail/linux-mtd/2009-August/026805.html
http://lists.infradead.org/pipermail/linux-mtd/2009-August/026809.html
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Kyungmin Park <kmpark@infradead.org>,
linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org,
tony@atomide.com, linux-omap@vger.kernel.org,
dwmw2@infradead.org, akpm@linux-foundation.org
Subject: Re: [PATCH] mtd: make onenand/generic.c more generic
Date: Fri, 7 Aug 2009 14:30:20 +0900 [thread overview]
Message-ID: <20090807053020.GA902@linux-sh.org> (raw)
In-Reply-To: <aec7e5c30908062228g737c1f6cr25f6c67c07d80bd9@mail.gmail.com>
On Fri, Aug 07, 2009 at 02:28:01PM +0900, Magnus Damm wrote:
> On Wed, Aug 5, 2009 at 1:41 PM, Magnus Damm<magnus.damm@gmail.com> wrote:
> >> On Tue, Aug 4, 2009 at 6:20 PM, Magnus Damm<magnus.damm@gmail.com> wrote:
> >>> From: Magnus Damm <damm@igel.co.jp>
> >>>
> >>> This patch removes the ARM dependency from the generic "onenand"
> >>> platform device driver. This change makes the driver useful for
> >>> other architectures as well. Needed for the SuperH kfr2r09 board.
> >
> > On Wed, Aug 5, 2009 at 1:24 PM, Kyungmin Park<kmpark@infradead.org> wrote:
> >> Good idea add the onenand_platform_data, but dont' agree the renaming
> >> the onenand-flash.
> >> Other boards are use it even though it's not released it
> >
> > I suspected so. But this is the only reason why changed the name. =)
> >
> > If we don't change the name then the platform device will be attached
> > to the platform driver as usual, but the old platform data structure
> > will use a different binary format compated to what the driver
> > expects.
> >
> > Changing the driver name makes sure that the old device disappears and
> > that people can move over to the new name and at the same time update
> > the platform data to the new format.
> >
> >> Others are good.
> >
> > Thanks.
> >
> > I can post an updated version where I keep the driver name unchanged
> > if you prefer that. But I'm pretty sure out-of-tree drivers will break
> > with NULL pointer accesses or similar if we update the platform data
> > format without changing the name. I don't think you want that. =)
>
> Any update on this?
>
You have failed at reading your email:
http://lists.infradead.org/pipermail/linux-mtd/2009-August/026805.html
http://lists.infradead.org/pipermail/linux-mtd/2009-August/026809.html
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Kyungmin Park <kmpark@infradead.org>,
linux-sh@vger.kernel.org, tony@atomide.com,
linux-mtd@lists.infradead.org, akpm@linux-foundation.org,
linux-omap@vger.kernel.org, dwmw2@infradead.org
Subject: Re: [PATCH] mtd: make onenand/generic.c more generic
Date: Fri, 07 Aug 2009 05:30:20 +0000 [thread overview]
Message-ID: <20090807053020.GA902@linux-sh.org> (raw)
In-Reply-To: <aec7e5c30908062228g737c1f6cr25f6c67c07d80bd9@mail.gmail.com>
On Fri, Aug 07, 2009 at 02:28:01PM +0900, Magnus Damm wrote:
> On Wed, Aug 5, 2009 at 1:41 PM, Magnus Damm<magnus.damm@gmail.com> wrote:
> >> On Tue, Aug 4, 2009 at 6:20 PM, Magnus Damm<magnus.damm@gmail.com> wrote:
> >>> From: Magnus Damm <damm@igel.co.jp>
> >>>
> >>> This patch removes the ARM dependency from the generic "onenand"
> >>> platform device driver. This change makes the driver useful for
> >>> other architectures as well. Needed for the SuperH kfr2r09 board.
> >
> > On Wed, Aug 5, 2009 at 1:24 PM, Kyungmin Park<kmpark@infradead.org> wrote:
> >> Good idea add the onenand_platform_data, but dont' agree the renaming
> >> the onenand-flash.
> >> Other boards are use it even though it's not released it
> >
> > I suspected so. But this is the only reason why changed the name. =)
> >
> > If we don't change the name then the platform device will be attached
> > to the platform driver as usual, but the old platform data structure
> > will use a different binary format compated to what the driver
> > expects.
> >
> > Changing the driver name makes sure that the old device disappears and
> > that people can move over to the new name and at the same time update
> > the platform data to the new format.
> >
> >> Others are good.
> >
> > Thanks.
> >
> > I can post an updated version where I keep the driver name unchanged
> > if you prefer that. But I'm pretty sure out-of-tree drivers will break
> > with NULL pointer accesses or similar if we update the platform data
> > format without changing the name. I don't think you want that. =)
>
> Any update on this?
>
You have failed at reading your email:
http://lists.infradead.org/pipermail/linux-mtd/2009-August/026805.html
http://lists.infradead.org/pipermail/linux-mtd/2009-August/026809.html
next prev parent reply other threads:[~2009-08-07 5:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 9:20 [PATCH] mtd: make onenand/generic.c more generic Magnus Damm
2009-08-04 9:20 ` Magnus Damm
2009-08-04 9:20 ` Magnus Damm
2009-08-05 4:24 ` Kyungmin Park
2009-08-05 4:24 ` Kyungmin Park
2009-08-05 4:24 ` Kyungmin Park
2009-08-05 4:41 ` Magnus Damm
2009-08-05 4:41 ` Magnus Damm
2009-08-05 4:41 ` Magnus Damm
2009-08-07 5:28 ` Magnus Damm
2009-08-07 5:28 ` Magnus Damm
2009-08-07 5:28 ` Magnus Damm
2009-08-07 5:30 ` Paul Mundt [this message]
2009-08-07 5:30 ` Paul Mundt
2009-08-07 5:30 ` Paul Mundt
2009-08-07 5:46 ` Magnus Damm
2009-08-07 5:46 ` Magnus Damm
2009-08-07 5:46 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090807053020.GA902@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=kmpark@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.