From: "Davidlohr Bueso A." <dave@gnu.org>
To: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] drivers/scsi: Check NULL for kmalloc() return
Date: Fri, 07 Aug 2009 18:39:53 +0000 [thread overview]
Message-ID: <20090807183953.GA22286@fencepost.gnu.org> (raw)
Verify that ch->dt is not NULL before using it:
ch-dt[elem] = value;
Signed-off-by: Davidlohr Bueso
---
drivers/scsi/ch.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c
index 7b1633a..96cbd20 100644
--- a/drivers/scsi/ch.c
+++ b/drivers/scsi/ch.c
@@ -353,6 +353,10 @@ ch_readconfig(scsi_changer *ch)
/* look up the devices of the data transfer elements */
ch->dt = kmalloc(ch->counts[CHET_DT]*sizeof(struct scsi_device),
GFP_KERNEL);
+
+ if (!ch->dt)
+ return -ENOMEM;
+
for (elem = 0; elem < ch->counts[CHET_DT]; elem++) {
id = -1;
lun = 0;
WARNING: multiple messages have this Message-ID (diff)
From: "Davidlohr Bueso A." <dave@gnu.org>
To: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] drivers/scsi: Check NULL for kmalloc() return
Date: Fri, 7 Aug 2009 14:39:53 -0400 [thread overview]
Message-ID: <20090807183953.GA22286@fencepost.gnu.org> (raw)
Verify that ch->dt is not NULL before using it:
ch-dt[elem] = value;
Signed-off-by: Davidlohr Bueso
---
drivers/scsi/ch.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c
index 7b1633a..96cbd20 100644
--- a/drivers/scsi/ch.c
+++ b/drivers/scsi/ch.c
@@ -353,6 +353,10 @@ ch_readconfig(scsi_changer *ch)
/* look up the devices of the data transfer elements */
ch->dt = kmalloc(ch->counts[CHET_DT]*sizeof(struct scsi_device),
GFP_KERNEL);
+
+ if (!ch->dt)
+ return -ENOMEM;
+
for (elem = 0; elem < ch->counts[CHET_DT]; elem++) {
id = -1;
lun = 0;
next reply other threads:[~2009-08-07 18:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 18:39 Davidlohr Bueso A. [this message]
2009-08-07 18:39 ` [PATCH] drivers/scsi: Check NULL for kmalloc() return Davidlohr Bueso A.
2009-08-07 18:54 ` Julia Lawall
2009-08-07 18:54 ` Julia Lawall
2009-08-07 19:44 ` Davidlohr Bueso A.
2009-08-07 19:44 ` Davidlohr Bueso A.
2009-08-07 19:56 ` Julia Lawall
2009-08-07 19:56 ` Julia Lawall
2009-08-07 20:17 ` Davidlohr Bueso A.
2009-08-07 20:17 ` Davidlohr Bueso A.
2009-08-07 20:33 ` Hannes Eder
2009-08-07 20:33 ` Hannes Eder
2009-08-07 20:42 ` Davidlohr Bueso A.
2009-08-07 20:42 ` Davidlohr Bueso A.
2009-08-07 19:54 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090807183953.GA22286@fencepost.gnu.org \
--to=dave@gnu.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.